um/stacktrace: Remove the pointless ULONG_MAX marker
authorThomas Gleixner <tglx@linutronix.de>
Wed, 10 Apr 2019 10:27:55 +0000 (12:27 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Sun, 14 Apr 2019 17:58:27 +0000 (19:58 +0200)
Terminating the last trace entry with ULONG_MAX is a completely pointless
exercise and none of the consumers can rely on it because it's
inconsistently implemented across architectures. In fact quite some of the
callers remove the entry and adjust stack_trace.nr_entries afterwards.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Alexander Potapenko <glider@google.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: linux-um@lists.infradead.org
Link: https://lkml.kernel.org/r/20190410103643.662853876@linutronix.de
arch/um/kernel/stacktrace.c

index ebe7bcf62684c5312aaec16bbe5cadd4f13ff595..bd95e020d5091858b3ec377ebca5e1127c59a956 100644 (file)
@@ -63,8 +63,6 @@ static const struct stacktrace_ops dump_ops = {
 static void __save_stack_trace(struct task_struct *tsk, struct stack_trace *trace)
 {
        dump_trace(tsk, &dump_ops, trace);
-       if (trace->nr_entries < trace->max_entries)
-               trace->entries[trace->nr_entries++] = ULONG_MAX;
 }
 
 void save_stack_trace(struct stack_trace *trace)