tcp: fix data delivery rate
authorEric Dumazet <edumazet@google.com>
Fri, 15 Sep 2017 23:47:42 +0000 (16:47 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 16 Sep 2017 16:07:01 +0000 (09:07 -0700)
Now skb->mstamp_skb is updated later, we also need to call
tcp_rate_skb_sent() after the update is done.

Fixes: 8c72c65b426b ("tcp: update skb->skb_mstamp more carefully")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_output.c

index a85a8c2948e54b931f8cd956aa7938f7efd355bd..1c839c99114cd22bbfbd181cf702acccb3aeb61b 100644 (file)
@@ -1002,8 +1002,6 @@ static int tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, int clone_it,
        if (clone_it) {
                TCP_SKB_CB(skb)->tx.in_flight = TCP_SKB_CB(skb)->end_seq
                        - tp->snd_una;
-               tcp_rate_skb_sent(sk, skb);
-
                oskb = skb;
                if (unlikely(skb_cloned(skb)))
                        skb = pskb_copy(skb, gfp_mask);
@@ -1128,9 +1126,10 @@ static int tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, int clone_it,
                tcp_enter_cwr(sk);
                err = net_xmit_eval(err);
        }
-       if (!err && oskb)
+       if (!err && oskb) {
                oskb->skb_mstamp = tp->tcp_mstamp;
-
+               tcp_rate_skb_sent(sk, oskb);
+       }
        return err;
 }