drm/panel: simple: fix osd070t1718_19ts sync drive edge
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 14 Nov 2019 09:39:50 +0000 (11:39 +0200)
committerSam Ravnborg <sam@ravnborg.org>
Sat, 22 Feb 2020 12:12:05 +0000 (13:12 +0100)
The panel datasheet says that the panel samples at falling edge, but
does not say anything about h/v sync signals. Testing shows that if the
sync signals are driven on falling edge, the picture on the panel will
be slightly shifted right.

Setting sync drive edge to the same as data drive edge fixes this issue.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20191114093950.4101-4-tomi.valkeinen@ti.com
drivers/gpu/drm/panel/panel-simple.c

index 82363d05bad4c13ef45f3766a477e4973fb73b66..05f1397e7ad11bc1baaa94af9ab64e6248085972 100644 (file)
@@ -2580,7 +2580,8 @@ static const struct panel_desc osddisplays_osd070t1718_19ts = {
                .height = 91,
        },
        .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
-       .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
+       .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE |
+               DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE,
        .connector_type = DRM_MODE_CONNECTOR_DPI,
 };