isdn/hisax: Remove unnecessary parenthesis
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 20 Sep 2018 04:05:23 +0000 (21:05 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 20 Sep 2018 06:10:44 +0000 (23:10 -0700)
Clang warns when more than one set of parentheses are used for single
conditional statements:

drivers/isdn/hisax/w6692.c:627:30: warning: equality comparison with
extraneous parentheses [-Wparentheses-equality]
                if ((cs->dc.w6692.ph_state == W_L1IND_DRD)) {
                     ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
drivers/isdn/hisax/w6692.c:627:30: note: remove extraneous parentheses
around the comparison to silence this warning
                if ((cs->dc.w6692.ph_state == W_L1IND_DRD)) {
                    ~                      ^             ~
drivers/isdn/hisax/w6692.c:627:30: note: use '=' to turn this equality
comparison into an assignment
                if ((cs->dc.w6692.ph_state == W_L1IND_DRD)) {
                                           ^~
                                           =
1 warning generated.

Remove the parentheses to silence this warning.

Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hisax/w6692.c

index c4be1644f5bb5e35636d69b44301c00d59e7a694..bb8e4b7e34ea8d7011d57812c90777d680066bdc 100644 (file)
@@ -624,7 +624,7 @@ W6692_l1hw(struct PStack *st, int pr, void *arg)
                break;
        case (HW_RESET | REQUEST):
                spin_lock_irqsave(&cs->lock, flags);
-               if ((cs->dc.w6692.ph_state == W_L1IND_DRD)) {
+               if (cs->dc.w6692.ph_state == W_L1IND_DRD) {
                        ph_command(cs, W_L1CMD_ECK);
                        spin_unlock_irqrestore(&cs->lock, flags);
                } else {