net/mlx5: FWTrace, Reduce stack usage
authorSaeed Mahameed <saeedm@mellanox.com>
Tue, 10 Sep 2019 19:35:59 +0000 (12:35 -0700)
committerSaeed Mahameed <saeedm@mellanox.com>
Tue, 10 Sep 2019 20:43:27 +0000 (13:43 -0700)
Mark mlx5_tracer_print_trace as noinline as the function only uses 512
bytes on the stack to avoid the following build warning:

drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c:660:13: error: stack frame size of 1032 bytes in function 'mlx5_fw_tracer_handle_traces' [-Werror,-Wframe-larger-than=]

Fixes: 70dd6fdb8987 ("net/mlx5: FW tracer, parse traces and kernel tracing support")
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c

index 2011eaf15cc5ef3ef33b38824046326d75456335..94d7b69a95c746ae6a44ffce9841ffb12d9bf7bb 100644 (file)
@@ -553,9 +553,10 @@ static void mlx5_fw_tracer_save_trace(struct mlx5_fw_tracer *tracer,
        mutex_unlock(&tracer->st_arr.lock);
 }
 
-static void mlx5_tracer_print_trace(struct tracer_string_format *str_frmt,
-                                   struct mlx5_core_dev *dev,
-                                   u64 trace_timestamp)
+static noinline
+void mlx5_tracer_print_trace(struct tracer_string_format *str_frmt,
+                            struct mlx5_core_dev *dev,
+                            u64 trace_timestamp)
 {
        char    tmp[512];