drm/i915: Remove bogus FIXME from SKL wm computation
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 13 Nov 2018 17:23:29 +0000 (19:23 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 7 Dec 2018 18:41:48 +0000 (20:41 +0200)
We do return an error when the watermark calculation fails, so
the FIXME claiming otherwise is outdated. Remove it.

Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181113172330.26069-2-ville.syrjala@linux.intel.com
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/intel_pm.c

index eadcece720ce047e6f83a1570ccf184e84c7ec73..8ed88b4a922016fbdb11c567400174e48f3c28cb 100644 (file)
@@ -5549,10 +5549,6 @@ skl_compute_wm(struct drm_atomic_state *state)
         * Note that the DDB allocation above may have added more CRTC's that
         * weren't otherwise being modified (and set bits in dirty_pipes) if
         * pipe allocations had to change.
-        *
-        * FIXME:  Now that we're doing this in the atomic check phase, we
-        * should allow skl_update_pipe_wm() to return failure in cases where
-        * no suitable watermark values can be found.
         */
        for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, cstate, i) {
                struct intel_crtc_state *intel_cstate =