ext4: use IS_ERR() to check for errors in ext4_error_file
authorDan Carpenter <error27@gmail.com>
Mon, 10 Jan 2011 17:10:50 +0000 (12:10 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 10 Jan 2011 17:10:50 +0000 (12:10 -0500)
d_path() returns an ERR_PTR and it doesn't return NULL.  This is in
ext4_error_file() and no one actually calls ext4_error_file().

Signed-off-by: Dan Carpenter <error27@gmail.com>
fs/ext4/super.c

index c228da112de0ce18b1317afcfe6a4d4bcb506108..d49e3b1ec41ec9a142c263196f7d11b22e8b7a9a 100644 (file)
@@ -437,7 +437,7 @@ void ext4_error_file(struct file *file, const char *function,
        save_error_info(inode->i_sb, function, line);
        va_start(args, fmt);
        path = d_path(&(file->f_path), pathname, sizeof(pathname));
-       if (!path)
+       if (IS_ERR(path))
                path = "(unknown)";
        printk(KERN_CRIT
               "EXT4-fs error (device %s): %s:%d: inode #%lu "