mediatek: mt8183: refine GIC driver
authorkenny liang <kenny.liang@mediatek.com>
Tue, 25 Jun 2019 07:33:48 +0000 (15:33 +0800)
committerkenny liang <kenny.liang@mediatek.com>
Tue, 10 Sep 2019 03:23:07 +0000 (11:23 +0800)
Refine MTK GIC driver.
Remove unused codes.

Signed-off-by: kenny liang <kenny.liang@mediatek.com>
Change-Id: I39e05ce7aa3c257e237fbc8e661cdde65cbcec7c

plat/mediatek/mt8183/include/mt_gic_v3.h
plat/mediatek/mt8183/plat_mt_gic.c

index e2706f46a0ab65c6c42aac3a74dd150d56827539..9d78ddb1091f293a376dae9aa01ba3f9e7eb07ba 100644 (file)
@@ -9,11 +9,6 @@
 
 #include <lib/mmio.h>
 
-enum irq_schedule_mode {
-       SW_MODE,
-       HW_MODE
-};
-
 #define GIC_INT_MASK (MCUCFG_BASE + 0x5e8)
 #define GIC500_ACTIVE_SEL_SHIFT 3
 #define GIC500_ACTIVE_SEL_MASK (0x7 << GIC500_ACTIVE_SEL_SHIFT)
index 21443799fd5053ffb483166e7f5db85fc56e7300..ccb72be429d05de390db9399f332ece389c11b1e 100644 (file)
@@ -1,14 +1,14 @@
 /*
- * Copyright (c) 2019, ARM Limited and Contributors. All rights reserved.
+ * Copyright (c) 2019, MediaTek Inc. All rights reserved.
  *
  * SPDX-License-Identifier: BSD-3-Clause
  */
 
+#include <assert.h>
 #include <common/bl_common.h>
 #include <common/debug.h>
 #include <drivers/arm/gicv3.h>
 #include <bl31/interrupt_mgmt.h>
-#include <../drivers/arm/gic/v3/gicv3_private.h>
 #include <mt_gic_v3.h>
 #include <mtk_plat_common.h>
 #include "plat_private.h"
 
 uintptr_t rdistif_base_addrs[PLATFORM_CORE_COUNT];
 
-/*
- * We save and restore the GICv3 context on system suspend. Allocate the
- * data in the designated EL3 Secure carve-out memory
- */
-gicv3_redist_ctx_t rdist_ctx __section("arm_el3_tzc_dram");
-gicv3_dist_ctx_t dist_ctx __section("arm_el3_tzc_dram");
-
+/* we save and restore the GICv3 context on system suspend */
+gicv3_redist_ctx_t rdist_ctx;
+gicv3_dist_ctx_t dist_ctx;
 
 static unsigned int mt_mpidr_to_core_pos(u_register_t mpidr)
 {
@@ -42,27 +38,6 @@ gicv3_driver_data_t mt_gicv3_data = {
        .mpidr_to_core_pos = mt_mpidr_to_core_pos,
 };
 
-void setup_int_schedule_mode(enum irq_schedule_mode mode,
-                            unsigned int active_cpu)
-{
-       assert(mode <= HW_MODE);
-       assert(active_cpu <= 0xFF);
-
-       if (mode == HW_MODE) {
-               mmio_write_32(GIC_INT_MASK,
-               (mmio_read_32(GIC_INT_MASK) & ~(GIC500_ACTIVE_SEL_MASK))
-               | (0x1 << GIC500_ACTIVE_SEL_SHIFT));
-       } else if (mode == SW_MODE) {
-               mmio_write_32(GIC_INT_MASK,
-               (mmio_read_32(GIC_INT_MASK) & ~(GIC500_ACTIVE_SEL_MASK)));
-       }
-
-       mmio_write_32(GIC_INT_MASK,
-               (mmio_read_32(GIC_INT_MASK) & ~(GIC500_ACTIVE_CPU_MASK))
-               | (active_cpu << GIC500_ACTIVE_CPU_SHIFT));
-       return;
-}
-
 void clear_sec_pol_ctl_en(void)
 {
        unsigned int i;
@@ -85,7 +60,6 @@ void mt_gic_init(void)
        gicv3_rdistif_init(plat_my_core_pos());
        gicv3_cpuif_enable(plat_my_core_pos());
 
-       setup_int_schedule_mode(SW_MODE, 0xf);
        clear_sec_pol_ctl_en();
 }
 
@@ -94,14 +68,6 @@ void mt_gic_set_pending(uint32_t irq)
        gicv3_set_interrupt_pending(irq, plat_my_core_pos());
 }
 
-uint32_t mt_gic_get_pending(uint32_t irq)
-{
-       uint32_t bit = 1 << (irq % 32);
-
-       return (mmio_read_32(gicv3_driver_data->gicd_base +
-                            GICD_ISPENDR + irq / 32 * 4) & bit) ? 1 : 0;
-}
-
 void mt_gic_cpuif_enable(void)
 {
        gicv3_cpuif_enable(plat_my_core_pos());