drm: Print the src/dst/clip rectangles in error in drm_plane_helper
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 16 Nov 2015 15:02:37 +0000 (17:02 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 24 Nov 2015 10:47:47 +0000 (11:47 +0100)
To aid in debugging failures, print the src,dst,clip rectangles
when drm_plane_helper_check_update() fails.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/drm_plane_helper.c

index d384ebcf0aaf52a63125c9599553fc24e6a7f87b..a6983d41920d99b26ebd3d928dbc67ff3ece93b9 100644 (file)
@@ -164,6 +164,8 @@ int drm_plane_helper_check_update(struct drm_plane *plane,
        vscale = drm_rect_calc_vscale(src, dest, min_scale, max_scale);
        if (hscale < 0 || vscale < 0) {
                DRM_DEBUG_KMS("Invalid scaling of plane\n");
+               drm_rect_debug_print("src: ", src, true);
+               drm_rect_debug_print("dst: ", dest, false);
                return -ERANGE;
        }
 
@@ -180,6 +182,8 @@ int drm_plane_helper_check_update(struct drm_plane *plane,
 
        if (!can_position && !drm_rect_equals(dest, clip)) {
                DRM_DEBUG_KMS("Plane must cover entire CRTC\n");
+               drm_rect_debug_print("dst: ", dest, false);
+               drm_rect_debug_print("clip: ", clip, false);
                return -EINVAL;
        }