scsi: qla2xxx: Suppress a Coveritiy complaint about integer overflow
authorBart Van Assche <bvanassche@acm.org>
Fri, 9 Aug 2019 03:01:50 +0000 (20:01 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 13 Aug 2019 01:34:07 +0000 (21:34 -0400)
This patch fixes the following Coverity complaint:

Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)
overflow_before_widen: Potentially overflowing expression dma_eng_num *
65536U with type unsigned int (32 bits, unsigned) is evaluated using 32-bit
arithmetic, and then used in a context that expects an expression of type
uint64_t (64 bits, unsigned).

Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Tested-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_nx2.c

index 369ac04d0454fe3d75e704291ca2123f6bf952ca..c056f466f1f4a829d35a2f160b5720b1edb24c51 100644 (file)
@@ -2810,7 +2810,7 @@ error:
 
 #define ISP8044_PEX_DMA_ENGINE_INDEX           8
 #define ISP8044_PEX_DMA_BASE_ADDRESS           0x77320000
-#define ISP8044_PEX_DMA_NUM_OFFSET             0x10000
+#define ISP8044_PEX_DMA_NUM_OFFSET             0x10000UL
 #define ISP8044_PEX_DMA_CMD_ADDR_LOW           0x0
 #define ISP8044_PEX_DMA_CMD_ADDR_HIGH          0x04
 #define ISP8044_PEX_DMA_CMD_STS_AND_CNTRL      0x08