V4L/DVB: drivers/media/dvb/siano: Remove double test

The same expression is tested twice and the result is the same each time.

The sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@expression@
expression E;
@@

(
* E
  || ... || E
|
* E
  && ... && E
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/dvb/siano/smscoreapi.c b/drivers/media/dvb/siano/smscoreapi.c
index ff3b0fa901b39f00e23250e20dda2502fbb42e04..135e45bd00c7c9064e9af88b96a55aafc3d2498a 100644 (file)
--- a/drivers/media/dvb/siano/smscoreapi.c
+++ b/drivers/media/dvb/siano/smscoreapi.c
@@ -1504,8 +1504,7 @@ int smscore_gpio_set_level(struct smscore_device_t *coredev, u8 PinNum,
                u32 msgData[3]; /* keep it 3 ! */
        } *pMsg;
 
-       if ((NewLevel > 1) || (PinNum > MAX_GPIO_PIN_NUMBER) ||
-                       (PinNum > MAX_GPIO_PIN_NUMBER))
+       if ((NewLevel > 1) || (PinNum > MAX_GPIO_PIN_NUMBER))
                return -EINVAL;
 
        totalLen = sizeof(struct SmsMsgHdr_ST) +