platform/x86: dell-laptop: Drop superfluous exported function
authorTakashi Iwai <tiwai@suse.de>
Mon, 26 Nov 2018 16:47:46 +0000 (17:47 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 28 Nov 2018 22:25:23 +0000 (23:25 +0100)
Since we've switched to the LED trigger for binding with HD-audio,
we can drop the exported function as well as the whole
linux/dell-led.h.

Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
drivers/platform/x86/dell-laptop.c
include/linux/dell-led.h [deleted file]

index 0db2dbf7b0d1c426b2d05da87f45c791cac7e60d..fb071e6a505827ca8a7ac3b1495d8f8024f7158d 100644 (file)
@@ -29,7 +29,6 @@
 #include <linux/mm.h>
 #include <linux/i8042.h>
 #include <linux/debugfs.h>
-#include <linux/dell-led.h>
 #include <linux/seq_file.h>
 #include <acpi/video.h>
 #include "dell-rbtn.h"
@@ -2109,17 +2108,17 @@ static struct notifier_block dell_laptop_notifier = {
        .notifier_call = dell_laptop_notifier_call,
 };
 
-int dell_micmute_led_set(int state)
+static int micmute_led_set(struct led_classdev *led_cdev,
+                          enum led_brightness brightness)
 {
        struct calling_interface_buffer buffer;
        struct calling_interface_token *token;
+       int state = brightness != LED_OFF;
 
        if (state == 0)
                token = dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE);
-       else if (state == 1)
-               token = dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE);
        else
-               return -EINVAL;
+               token = dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE);
 
        if (!token)
                return -ENODEV;
@@ -2127,18 +2126,7 @@ int dell_micmute_led_set(int state)
        dell_fill_request(&buffer, token->location, token->value, 0, 0);
        dell_send_request(&buffer, CLASS_TOKEN_WRITE, SELECT_TOKEN_STD);
 
-       return state;
-}
-EXPORT_SYMBOL_GPL(dell_micmute_led_set);
-
-static int micmute_led_set(struct led_classdev *led_cdev,
-                          enum led_brightness brightness)
-{
-       int state = brightness != LED_OFF;
-       int err;
-
-       err = dell_micmute_led_set(state);
-       return err < 0 ? err : 0;
+       return 0;
 }
 
 static struct led_classdev micmute_led_cdev = {
diff --git a/include/linux/dell-led.h b/include/linux/dell-led.h
deleted file mode 100644 (file)
index 9252147..0000000
+++ /dev/null
@@ -1,7 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef __DELL_LED_H__
-#define __DELL_LED_H__
-
-int dell_micmute_led_set(int on);
-
-#endif