mac80211: dereference RCU protected probe_resp pointer correctly
authorArik Nemtsov <arik@wizery.com>
Sat, 19 Nov 2011 08:51:26 +0000 (10:51 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 28 Nov 2011 19:36:21 +0000 (14:36 -0500)
This fixes a sparse warning:

cfg.c:502:13: warning: incorrect type in assignment (different address spaces)
cfg.c:502:13:    expected struct sk_buff *old
cfg.c:502:13:    got struct sk_buff [noderef] <asn:4>*probe_resp

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Arik Nemtsov <arik@wizery.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/cfg.c

index f947ac6bb67cee75697420b5de2e72895646deef..a29f06c0bcf06e368fdd8173dd6746483f57c03a 100644 (file)
@@ -509,7 +509,7 @@ static int ieee80211_set_probe_resp(struct ieee80211_sub_if_data *sdata,
        if (!resp || !resp_len)
                return -EINVAL;
 
-       old = sdata->u.ap.probe_resp;
+       old = rtnl_dereference(sdata->u.ap.probe_resp);
 
        new = dev_alloc_skb(resp_len);
        if (!new)