staging: rtl8712: Fixed a comparision coding style warning.
authorRakhi Sharma <rakhish1994@gmail.com>
Sat, 13 Feb 2016 05:24:20 +0000 (10:54 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 Feb 2016 00:49:09 +0000 (16:49 -0800)
WARNING: Comparisons should place the constant on the right side of the test
Fixed this warning by placing the constant on right side.

Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>-
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8712/rtl8712_efuse.c

index eaa93fbb95a30d2d72624140dc96053135c853c0..76f60ba5ee9b2bf297f0dcffadccb753810dd11b 100644 (file)
@@ -161,7 +161,7 @@ static u8 efuse_is_empty(struct _adapter *padapter, u8 *empty)
 
        /* read one byte to check if E-Fuse is empty */
        if (efuse_one_byte_rw(padapter, true, 0, &value)) {
-               if (0xFF == value)
+               if (value == 0xFF)
                        *empty = true;
                else
                        *empty = false;
@@ -345,7 +345,7 @@ static u8 fix_header(struct _adapter *padapter, u8 header, u16 header_addr)
                                ret = false;
                        } else if (pkt.data[i * 2] != value) {
                                ret = false;
-                               if (0xFF == value) /* write again */
+                               if (value == 0xFF) /* write again */
                                        efuse_one_byte_write(padapter, addr,
                                                        pkt.data[i * 2]);
                        }
@@ -353,7 +353,7 @@ static u8 fix_header(struct _adapter *padapter, u8 header, u16 header_addr)
                                ret = false;
                        } else if (pkt.data[i * 2 + 1] != value) {
                                ret = false;
-                               if (0xFF == value) /* write again */
+                               if (value == 0xFF) /* write again */
                                        efuse_one_byte_write(padapter, addr + 1,
                                                             pkt.data[i * 2 +
                                                                      1]);
@@ -420,7 +420,7 @@ u8 r8712_efuse_pg_packet_write(struct _adapter *padapter, const u8 offset,
                }
                /* write header fail */
                bResult = false;
-               if (0xFF == efuse_data)
+               if (efuse_data == 0xFF)
                        return bResult; /* nothing damaged. */
                /* call rescue procedure */
                if (!fix_header(padapter, efuse_data, efuse_addr))