lightnvm: pblk: assume that chunks are closed on 1.2 devices
authorHans Holmberg <hans.holmberg@cnexlabs.com>
Fri, 13 Jul 2018 08:48:45 +0000 (10:48 +0200)
committerJens Axboe <axboe@kernel.dk>
Fri, 13 Jul 2018 14:14:49 +0000 (08:14 -0600)
We can't know if a block is closed or not on 1.2 devices, so assume
closed state to make sure that blocks are erased before writing.

Fixes: 32ef9412c114 ("lightnvm: pblk: implement get log report chunk")
Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/lightnvm/pblk-init.c

index d023ea6116bc3fc49421d906884fcbf9635b8ee5..537e98f2b24a2d67b4b23b8c4b9a135672d27848 100644 (file)
@@ -719,10 +719,11 @@ static int pblk_setup_line_meta_12(struct pblk *pblk, struct pblk_line *line,
 
                /*
                 * In 1.2 spec. chunk state is not persisted by the device. Thus
-                * some of the values are reset each time pblk is instantiated.
+                * some of the values are reset each time pblk is instantiated,
+                * so we have to assume that the block is closed.
                 */
                if (lun_bb_meta[line->id] == NVM_BLK_T_FREE)
-                       chunk->state =  NVM_CHK_ST_FREE;
+                       chunk->state =  NVM_CHK_ST_CLOSED;
                else
                        chunk->state = NVM_CHK_ST_OFFLINE;