drm/rockchip: Delete an unnecessary check before drm_gem_object_unreference_unlocked()
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 15 Jul 2016 13:23:22 +0000 (15:23 +0200)
committerMark Yao <mark.yao@rock-chips.com>
Tue, 19 Jul 2016 02:02:30 +0000 (10:02 +0800)
The drm_gem_object_unreference_unlocked() function tests whether
its argument is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
drivers/gpu/drm/rockchip/rockchip_drm_fb.c

index b33debc0fa92fd4994ffc8b27508dd8f4b83bb08..55c52734c52d3f63895f1cac04c639df0a41f503 100644 (file)
@@ -44,14 +44,10 @@ struct drm_gem_object *rockchip_fb_get_gem_obj(struct drm_framebuffer *fb,
 static void rockchip_drm_fb_destroy(struct drm_framebuffer *fb)
 {
        struct rockchip_drm_fb *rockchip_fb = to_rockchip_fb(fb);
-       struct drm_gem_object *obj;
        int i;
 
-       for (i = 0; i < ROCKCHIP_MAX_FB_BUFFER; i++) {
-               obj = rockchip_fb->obj[i];
-               if (obj)
-                       drm_gem_object_unreference_unlocked(obj);
-       }
+       for (i = 0; i < ROCKCHIP_MAX_FB_BUFFER; i++)
+               drm_gem_object_unreference_unlocked(rockchip_fb->obj[i]);
 
        drm_framebuffer_cleanup(fb);
        kfree(rockchip_fb);