bonding: use pre-defined macro in bond_mode_name instead of magic number 0
authorWang Sheng-Hui <shhuiw@gmail.com>
Wed, 24 Jul 2013 06:53:26 +0000 (14:53 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Jul 2013 20:53:49 +0000 (13:53 -0700)
We have BOND_MODE_ROUNDROBIN pre-defined as 0, and it's the lowest
mode number.
Use it to check the arg lower bound instead of magic number 0 in
bond_mode_name.

Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_main.c

index 414d07ef65401ed0990a7f44610f69537e2ecdd9..fc10c12bb304de1980d023b1d3e0d1aa8df778c0 100644 (file)
@@ -273,7 +273,7 @@ const char *bond_mode_name(int mode)
                [BOND_MODE_ALB] = "adaptive load balancing",
        };
 
-       if (mode < 0 || mode > BOND_MODE_ALB)
+       if (mode < BOND_MODE_ROUNDROBIN || mode > BOND_MODE_ALB)
                return "unknown";
 
        return names[mode];