kcm: remove a useless copy_from_user()
authorWANG Cong <xiyou.wangcong@gmail.com>
Thu, 13 Apr 2017 18:38:02 +0000 (11:38 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Apr 2017 17:28:48 +0000 (13:28 -0400)
struct kcm_clone only contains fd, and kcm_clone() only
writes this struct, so there is no need to copy it from user.

Cc: Tom Herbert <tom@herbertland.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/kcm/kcmsock.c

index 31762f76cdb5f2a3ec322135068402be532218ed..deca20fb2ce2e5e50063e58ec2c0d9d6239d3bd4 100644 (file)
@@ -1707,11 +1707,7 @@ static int kcm_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
                struct kcm_clone info;
                struct socket *newsock = NULL;
 
-               if (copy_from_user(&info, (void __user *)arg, sizeof(info)))
-                       return -EFAULT;
-
                err = kcm_clone(sock, &info, &newsock);
-
                if (!err) {
                        if (copy_to_user((void __user *)arg, &info,
                                         sizeof(info))) {