selftests/net: fix warnings in TFO key rotation selftest

One warning each on signedness, unused variable and return type.

Fixes: 10fbcdd12aa2 ("selftests/net: add TFO key rotation selftest")
Signed-off-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/tools/testing/selftests/net/tcp_fastopen_backup_key.c b/tools/testing/selftests/net/tcp_fastopen_backup_key.c
index 58bb77d9e7e14f3eb381a5db4fd784f76dae2739..9c55ec44fc43580ef81e365e432f5db435b8f5b4 100644 (file)
--- a/tools/testing/selftests/net/tcp_fastopen_backup_key.c
+++ b/tools/testing/selftests/net/tcp_fastopen_backup_key.c
@@ -51,7 +51,7 @@ static const int PORT = 8891;
 static void get_keys(int fd, uint32_t *keys)
 {
        char buf[128];
-       int len = KEY_LENGTH * 2;
+       socklen_t len = KEY_LENGTH * 2;
 
        if (do_sockopt) {
                if (getsockopt(fd, SOL_TCP, TCP_FASTOPEN_KEY, keys, &len))
@@ -210,14 +210,13 @@ static bool is_listen_fd(int fd)
        return false;
 }
 
-static int rotate_key(int fd)
+static void rotate_key(int fd)
 {
        static int iter;
        static uint32_t new_key[4];
        uint32_t keys[8];
        uint32_t tmp_key[4];
        int i;
-       int len = KEY_LENGTH * 2;
 
        if (iter < N_LISTEN) {
                /* first set new key as backups */