hwmon: (smm665): Return error from i2c_smbus_read_word_swapped
authorGuenter Roeck <linux@roeck-us.net>
Wed, 12 Feb 2014 05:38:31 +0000 (21:38 -0800)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 3 Mar 2014 16:01:03 +0000 (08:01 -0800)
There is no reason to replace one error code with another,
and returning -1 as error code is wrong anyway.

Smatch log:
drivers/hwmon/smm665.c:225 smm665_read_adc() info: why not propagate 'rv'
from i2c_smbus_read_word_swapped() instead of (-1)?

Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/smm665.c

index d9e1b7de78da7798b2a7103282ad4c7d176aaaaf..4ef5802df6d85f9a4bf9910c67f11cdebf868a36 100644 (file)
@@ -222,7 +222,7 @@ static int smm665_read_adc(struct smm665_data *data, int adc)
        rv = i2c_smbus_read_word_swapped(client, 0);
        if (rv < 0) {
                dev_dbg(&client->dev, "Failed to read ADC value: error %d", rv);
-               return -1;
+               return rv;
        }
        /*
         * Validate/verify readback adc channel (in bit 11..14).