virt_wifi: Remove REGULATORY_WIPHY_SELF_MANAGED
authorCody Schuffelen <schuffelen@google.com>
Wed, 6 Feb 2019 23:54:15 +0000 (15:54 -0800)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 11 Feb 2019 16:10:48 +0000 (17:10 +0100)
REGULATORY_WIPHY_SELF_MANAGED as set here breaks NL80211_CMD_GET_REG,
because it expects the wiphy to do regulatory management. Since
virt_wifi does not do regulatory management, this triggers a WARN_ON in
NL80211_CMD_GET_REG and fails the netlink command.

Removing REGULATORY_WIPHY_SELF_MANAGED fixes the problem and the virtual
wireless network continues to work.

Signed-off-by: Cody Schuffelen <schuffelen@google.com>
Acked-by: Alistair Strachan <astrachan@google.com>
Acked-by: Greg Hartman <ghartman@google.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/virt_wifi.c

index 71044c6cfd8cc8b6704cf8ca7a267b3161a8713b..606999f102ebf9d1a3b02645fceefa7a353339c0 100644 (file)
@@ -360,7 +360,6 @@ static struct wiphy *virt_wifi_make_wiphy(void)
        wiphy->bands[NL80211_BAND_5GHZ] = &band_5ghz;
        wiphy->bands[NL80211_BAND_60GHZ] = NULL;
 
-       wiphy->regulatory_flags = REGULATORY_WIPHY_SELF_MANAGED;
        wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
 
        priv = wiphy_priv(wiphy);