b43/legacy: port to cfg80211 rfkill
authorJohannes Berg <johannes@sipsolutions.net>
Sun, 7 Jun 2009 17:30:34 +0000 (12:30 -0500)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 10 Jun 2009 17:27:54 +0000 (13:27 -0400)
This ports the b43/legacy rfkill code to the new API offered
by cfg80211 and thus removes a lot of useless stuff.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Michael Buesch <mb@bu3sch.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
15 files changed:
drivers/net/wireless/b43/Kconfig
drivers/net/wireless/b43/Makefile
drivers/net/wireless/b43/b43.h
drivers/net/wireless/b43/leds.c
drivers/net/wireless/b43/main.c
drivers/net/wireless/b43/phy_common.h
drivers/net/wireless/b43/rfkill.c
drivers/net/wireless/b43/rfkill.h
drivers/net/wireless/b43legacy/Kconfig
drivers/net/wireless/b43legacy/Makefile
drivers/net/wireless/b43legacy/b43legacy.h
drivers/net/wireless/b43legacy/leds.c
drivers/net/wireless/b43legacy/main.c
drivers/net/wireless/b43legacy/rfkill.c
drivers/net/wireless/b43legacy/rfkill.h

index 07a99e3faf94ad0812bc13e4ce27d7c92f1137b3..67f564e372250add1492af4149ebade112e60519 100644 (file)
@@ -98,13 +98,6 @@ config B43_LEDS
        depends on B43 && MAC80211_LEDS && (LEDS_CLASS = y || LEDS_CLASS = B43)
        default y
 
-# This config option automatically enables b43 RFKILL support,
-# if it's possible.
-config B43_RFKILL
-       bool
-       depends on B43 && (RFKILL = y || RFKILL = B43)
-       default y
-
 # This config option automatically enables b43 HW-RNG support,
 # if the HW-RNG core is enabled.
 config B43_HWRNG
index 281ef8310350e559752f0a44a6d9f0744cbd466c..da379f4b0c3a31f9bbfff19c4367b0ff2ff10a21 100644 (file)
@@ -13,7 +13,7 @@ b43-y                         += lo.o
 b43-y                          += wa.o
 b43-y                          += dma.o
 b43-$(CONFIG_B43_PIO)          += pio.o
-b43-$(CONFIG_B43_RFKILL)       += rfkill.o
+b43-y                          += rfkill.o
 b43-$(CONFIG_B43_LEDS)         += leds.o
 b43-$(CONFIG_B43_PCMCIA)       += pcmcia.o
 b43-$(CONFIG_B43_DEBUG)                += debugfs.o
index 4e8ad841c3c5a3cab7b8c123dc49d5da749cfd9c..75aede02f932f3c45e3eebc4413015a002141ace 100644 (file)
@@ -631,9 +631,6 @@ struct b43_wl {
        char rng_name[30 + 1];
 #endif /* CONFIG_B43_HWRNG */
 
-       /* The RF-kill button */
-       struct b43_rfkill rfkill;
-
        /* List of all wireless devices on this chip */
        struct list_head devlist;
        u8 nr_devs;
index 9a498d3fc6536b73269ac8c85eadb047bf47d7cb..c8b317094c31b489dfbb9091bb7c648f3060d927 100644 (file)
@@ -28,6 +28,7 @@
 
 #include "b43.h"
 #include "leds.h"
+#include "rfkill.h"
 
 
 static void b43_led_turn_on(struct b43_wldev *dev, u8 led_index,
@@ -164,10 +165,10 @@ static void b43_map_led(struct b43_wldev *dev,
                snprintf(name, sizeof(name),
                         "b43-%s::radio", wiphy_name(hw->wiphy));
                b43_register_led(dev, &dev->led_radio, name,
-                                b43_rfkill_led_name(dev),
+                                ieee80211_get_radio_led_name(hw),
                                 led_index, activelow);
-               /* Sync the RF-kill LED state with the switch state. */
-               if (dev->radio_hw_enable)
+               /* Sync the RF-kill LED state with radio and switch states. */
+               if (dev->phy.radio_on && b43_is_hw_radio_enabled(dev))
                        b43_led_turn_on(dev, led_index, activelow);
                break;
        case B43_LED_WEIRD:
index 1d3e40095ada06bba6ff0a35b111fee6e72ba291..5d9f1981f2ce8a9edda779d087a2f14c11c35843 100644 (file)
@@ -4298,7 +4298,6 @@ static int b43_op_start(struct ieee80211_hw *hw)
        struct b43_wldev *dev = wl->current_dev;
        int did_init = 0;
        int err = 0;
-       bool do_rfkill_exit = 0;
 
        /* Kill all old instance specific information to make sure
         * the card won't use it in the short timeframe between start
@@ -4312,18 +4311,12 @@ static int b43_op_start(struct ieee80211_hw *hw)
        wl->beacon1_uploaded = 0;
        wl->beacon_templates_virgin = 1;
 
-       /* First register RFkill.
-        * LEDs that are registered later depend on it. */
-       b43_rfkill_init(dev);
-
        mutex_lock(&wl->mutex);
 
        if (b43_status(dev) < B43_STAT_INITIALIZED) {
                err = b43_wireless_core_init(dev);
-               if (err) {
-                       do_rfkill_exit = 1;
+               if (err)
                        goto out_mutex_unlock;
-               }
                did_init = 1;
        }
 
@@ -4332,17 +4325,16 @@ static int b43_op_start(struct ieee80211_hw *hw)
                if (err) {
                        if (did_init)
                                b43_wireless_core_exit(dev);
-                       do_rfkill_exit = 1;
                        goto out_mutex_unlock;
                }
        }
 
+       /* XXX: only do if device doesn't support rfkill irq */
+       wiphy_rfkill_start_polling(hw->wiphy);
+
  out_mutex_unlock:
        mutex_unlock(&wl->mutex);
 
-       if (do_rfkill_exit)
-               b43_rfkill_exit(dev);
-
        return err;
 }
 
@@ -4351,7 +4343,6 @@ static void b43_op_stop(struct ieee80211_hw *hw)
        struct b43_wl *wl = hw_to_b43_wl(hw);
        struct b43_wldev *dev = wl->current_dev;
 
-       b43_rfkill_exit(dev);
        cancel_work_sync(&(wl->beacon_update_trigger));
 
        mutex_lock(&wl->mutex);
@@ -4433,6 +4424,7 @@ static const struct ieee80211_ops b43_hw_ops = {
        .sta_notify             = b43_op_sta_notify,
        .sw_scan_start          = b43_op_sw_scan_start_notifier,
        .sw_scan_complete       = b43_op_sw_scan_complete_notifier,
+       .rfkill_poll            = b43_rfkill_poll,
 };
 
 /* Hard-reset the chip. Do not call this directly.
@@ -4920,7 +4912,7 @@ static struct ssb_driver b43_ssb_driver = {
 static void b43_print_driverinfo(void)
 {
        const char *feat_pci = "", *feat_pcmcia = "", *feat_nphy = "",
-                  *feat_leds = "", *feat_rfkill = "";
+                  *feat_leds = "";
 
 #ifdef CONFIG_B43_PCI_AUTOSELECT
        feat_pci = "P";
@@ -4933,15 +4925,12 @@ static void b43_print_driverinfo(void)
 #endif
 #ifdef CONFIG_B43_LEDS
        feat_leds = "L";
-#endif
-#ifdef CONFIG_B43_RFKILL
-       feat_rfkill = "R";
 #endif
        printk(KERN_INFO "Broadcom 43xx driver loaded "
-              "[ Features: %s%s%s%s%s, Firmware-ID: "
+              "[ Features: %s%s%s%s, Firmware-ID: "
               B43_SUPPORTED_FIRMWARE_ID " ]\n",
               feat_pci, feat_pcmcia, feat_nphy,
-              feat_leds, feat_rfkill);
+              feat_leds);
 }
 
 static int __init b43_init(void)
index f4c2d79cbc894fe8a20d301b3253da9d766e94e0..44cc918e4fc6ee097d4721b22ea18af32a3721a0 100644 (file)
@@ -1,7 +1,7 @@
 #ifndef LINUX_B43_PHY_COMMON_H_
 #define LINUX_B43_PHY_COMMON_H_
 
-#include <linux/rfkill.h>
+#include <linux/types.h>
 
 struct b43_wldev;
 
index 96047843cd5626c9642f2ae29ffc31377ab5dd11..31e55999893f7084803221af05cb741e443ecf11 100644 (file)
 
 */
 
-#include "rfkill.h"
 #include "b43.h"
-#include "phy_common.h"
-
-#include <linux/kmod.h>
 
 
 /* Returns TRUE, if the radio is enabled in hardware. */
-static bool b43_is_hw_radio_enabled(struct b43_wldev *dev)
+bool b43_is_hw_radio_enabled(struct b43_wldev *dev)
 {
        if (dev->phy.rev >= 3) {
                if (!(b43_read32(dev, B43_MMIO_RADIO_HWENABLED_HI)
@@ -45,110 +41,39 @@ static bool b43_is_hw_radio_enabled(struct b43_wldev *dev)
 }
 
 /* The poll callback for the hardware button. */
-static void b43_rfkill_poll(struct rfkill *rfkill, void *data)
+void b43_rfkill_poll(struct ieee80211_hw *hw)
 {
-       struct b43_wldev *dev = data;
-       struct b43_wl *wl = dev->wl;
+       struct b43_wl *wl = hw_to_b43_wl(hw);
+       struct b43_wldev *dev = wl->current_dev;
+       struct ssb_bus *bus = dev->dev->bus;
        bool enabled;
+       bool brought_up = false;
 
        mutex_lock(&wl->mutex);
        if (unlikely(b43_status(dev) < B43_STAT_INITIALIZED)) {
-               mutex_unlock(&wl->mutex);
-               return;
+               if (ssb_bus_powerup(bus, 0)) {
+                       mutex_unlock(&wl->mutex);
+                       return;
+               }
+               ssb_device_enable(dev->dev, 0);
+               brought_up = true;
        }
+
        enabled = b43_is_hw_radio_enabled(dev);
+
        if (unlikely(enabled != dev->radio_hw_enable)) {
                dev->radio_hw_enable = enabled;
                b43info(wl, "Radio hardware status changed to %s\n",
                        enabled ? "ENABLED" : "DISABLED");
-               enabled = !rfkill_set_hw_state(rfkill, !enabled);
+               wiphy_rfkill_set_hw_state(hw->wiphy, !enabled);
                if (enabled != dev->phy.radio_on)
                        b43_software_rfkill(dev, !enabled);
        }
-       mutex_unlock(&wl->mutex);
-}
-
-/* Called when the RFKILL toggled in software. */
-static int b43_rfkill_soft_set(void *data, bool blocked)
-{
-       struct b43_wldev *dev = data;
-       struct b43_wl *wl = dev->wl;
-       int err = -EINVAL;
-
-       if (WARN_ON(!wl->rfkill.registered))
-               return -EINVAL;
 
-       mutex_lock(&wl->mutex);
-
-       if (b43_status(dev) < B43_STAT_INITIALIZED)
-               goto out_unlock;
-
-       if (!dev->radio_hw_enable)
-               goto out_unlock;
+       if (brought_up) {
+               ssb_device_disable(dev->dev, 0);
+               ssb_bus_may_powerdown(bus);
+       }
 
-       if (!blocked != dev->phy.radio_on)
-               b43_software_rfkill(dev, blocked);
-       err = 0;
-out_unlock:
        mutex_unlock(&wl->mutex);
-       return err;
-}
-
-const char *b43_rfkill_led_name(struct b43_wldev *dev)
-{
-       struct b43_rfkill *rfk = &(dev->wl->rfkill);
-
-       if (!rfk->registered)
-               return NULL;
-       return rfkill_get_led_trigger_name(rfk->rfkill);
-}
-
-static const struct rfkill_ops b43_rfkill_ops = {
-       .set_block = b43_rfkill_soft_set,
-       .poll = b43_rfkill_poll,
-};
-
-void b43_rfkill_init(struct b43_wldev *dev)
-{
-       struct b43_wl *wl = dev->wl;
-       struct b43_rfkill *rfk = &(wl->rfkill);
-       int err;
-
-       rfk->registered = 0;
-
-       snprintf(rfk->name, sizeof(rfk->name),
-                "b43-%s", wiphy_name(wl->hw->wiphy));
-
-       rfk->rfkill = rfkill_alloc(rfk->name,
-                                  dev->dev->dev,
-                                  RFKILL_TYPE_WLAN,
-                                  &b43_rfkill_ops, dev);
-       if (!rfk->rfkill)
-               goto out_error;
-
-       err = rfkill_register(rfk->rfkill);
-       if (err)
-               goto err_free;
-
-       rfk->registered = 1;
-
-       return;
- err_free:
-       rfkill_destroy(rfk->rfkill);
- out_error:
-       rfk->registered = 0;
-       b43warn(wl, "RF-kill button init failed\n");
-}
-
-void b43_rfkill_exit(struct b43_wldev *dev)
-{
-       struct b43_rfkill *rfk = &(dev->wl->rfkill);
-
-       if (!rfk->registered)
-               return;
-       rfk->registered = 0;
-
-       rfkill_unregister(rfk->rfkill);
-       rfkill_destroy(rfk->rfkill);
-       rfk->rfkill = NULL;
 }
index da497e01bbb1aad6d34fd68f4150dbe9c49a7a4f..f046c3ca0519bde676955a74b4074c26e8a39caf 100644 (file)
@@ -1,49 +1,11 @@
 #ifndef B43_RFKILL_H_
 #define B43_RFKILL_H_
 
+struct ieee80211_hw;
 struct b43_wldev;
 
+void b43_rfkill_poll(struct ieee80211_hw *hw);
 
-#ifdef CONFIG_B43_RFKILL
-
-#include <linux/rfkill.h>
-
-
-struct b43_rfkill {
-       /* The RFKILL subsystem data structure */
-       struct rfkill *rfkill;
-       /* Did initialization succeed? Used for freeing. */
-       bool registered;
-       /* The unique name of this rfkill switch */
-       char name[sizeof("b43-phy4294967295")];
-};
-
-/* The init function returns void, because we are not interested
- * in failing the b43 init process when rfkill init failed. */
-void b43_rfkill_init(struct b43_wldev *dev);
-void b43_rfkill_exit(struct b43_wldev *dev);
-
-const char *b43_rfkill_led_name(struct b43_wldev *dev);
-
-
-#else /* CONFIG_B43_RFKILL */
-/* No RFKILL support. */
-
-struct b43_rfkill {
-       /* empty */
-};
-
-static inline void b43_rfkill_init(struct b43_wldev *dev)
-{
-}
-static inline void b43_rfkill_exit(struct b43_wldev *dev)
-{
-}
-static inline char * b43_rfkill_led_name(struct b43_wldev *dev)
-{
-       return NULL;
-}
-
-#endif /* CONFIG_B43_RFKILL */
+bool b43_is_hw_radio_enabled(struct b43_wldev *dev);
 
 #endif /* B43_RFKILL_H_ */
index 6893f439df700eb2b39a7937f9cbb5e1972a2726..94a46347805370ccc99e51ea651f6999893c227a 100644 (file)
@@ -42,14 +42,6 @@ config B43LEGACY_LEDS
        depends on B43LEGACY && MAC80211_LEDS && (LEDS_CLASS = y || LEDS_CLASS = B43LEGACY)
        default y
 
-# RFKILL support
-# This config option automatically enables b43legacy RFKILL support,
-# if it's possible.
-config B43LEGACY_RFKILL
-       bool
-       depends on B43LEGACY && (RFKILL = y || RFKILL = B43LEGACY)
-       default y
-
 # This config option automatically enables b43 HW-RNG support,
 # if the HW-RNG core is enabled.
 config B43LEGACY_HWRNG
index 80cdb73bd140c4b42a37d464ce8f676211c5f612..227a77e8436215944948079bb631311cfe5c41be 100644 (file)
@@ -6,7 +6,7 @@ b43legacy-y                             += radio.o
 b43legacy-y                            += sysfs.o
 b43legacy-y                            += xmit.o
 # b43 RFKILL button support
-b43legacy-$(CONFIG_B43LEGACY_RFKILL)   += rfkill.o
+b43legacy-y                            += rfkill.o
 # b43legacy LED support
 b43legacy-$(CONFIG_B43LEGACY_LEDS)     += leds.o
 # b43legacy debugging
index 19a4b0bc0d872c3de0b99c2c45751807b701b191..77fda148ac4684b904e996095b1e7c68d3fa9469 100644 (file)
@@ -602,9 +602,6 @@ struct b43legacy_wl {
        char rng_name[30 + 1];
 #endif
 
-       /* The RF-kill button */
-       struct b43legacy_rfkill rfkill;
-
        /* List of all wireless devices on this chip */
        struct list_head devlist;
        u8 nr_devs;
index 538d3117594bd4e4c77c65ae3abe5a0a11bdeb6f..37e9be893560a19e938ea026044d879f31932238 100644 (file)
@@ -28,6 +28,7 @@
 
 #include "b43legacy.h"
 #include "leds.h"
+#include "rfkill.h"
 
 
 static void b43legacy_led_turn_on(struct b43legacy_wldev *dev, u8 led_index,
@@ -164,10 +165,10 @@ static void b43legacy_map_led(struct b43legacy_wldev *dev,
                snprintf(name, sizeof(name),
                         "b43legacy-%s::radio", wiphy_name(hw->wiphy));
                b43legacy_register_led(dev, &dev->led_radio, name,
-                                b43legacy_rfkill_led_name(dev),
+                                ieee80211_get_radio_led_name(hw),
                                 led_index, activelow);
-               /* Sync the RF-kill LED state with the switch state. */
-               if (dev->radio_hw_enable)
+               /* Sync the RF-kill LED state with radio and switch states. */
+               if (dev->phy.radio_on && b43legacy_is_hw_radio_enabled(dev))
                        b43legacy_led_turn_on(dev, led_index, activelow);
                break;
        case B43legacy_LED_WEIRD:
index f6f3fbf0a2f47c7c8b9e2a8da1488e3acbfa552a..e5136fb65dddb066f3d6ab65b0671bf8386c3b97 100644 (file)
@@ -3431,11 +3431,6 @@ static int b43legacy_op_start(struct ieee80211_hw *hw)
        struct b43legacy_wldev *dev = wl->current_dev;
        int did_init = 0;
        int err = 0;
-       bool do_rfkill_exit = 0;
-
-       /* First register RFkill.
-        * LEDs that are registered later depend on it. */
-       b43legacy_rfkill_init(dev);
 
        /* Kill all old instance specific information to make sure
         * the card won't use it in the short timeframe between start
@@ -3451,10 +3446,8 @@ static int b43legacy_op_start(struct ieee80211_hw *hw)
 
        if (b43legacy_status(dev) < B43legacy_STAT_INITIALIZED) {
                err = b43legacy_wireless_core_init(dev);
-               if (err) {
-                       do_rfkill_exit = 1;
+               if (err)
                        goto out_mutex_unlock;
-               }
                did_init = 1;
        }
 
@@ -3463,17 +3456,15 @@ static int b43legacy_op_start(struct ieee80211_hw *hw)
                if (err) {
                        if (did_init)
                                b43legacy_wireless_core_exit(dev);
-                       do_rfkill_exit = 1;
                        goto out_mutex_unlock;
                }
        }
 
+       wiphy_rfkill_start_polling(hw->wiphy);
+
 out_mutex_unlock:
        mutex_unlock(&wl->mutex);
 
-       if (do_rfkill_exit)
-               b43legacy_rfkill_exit(dev);
-
        return err;
 }
 
@@ -3482,7 +3473,6 @@ static void b43legacy_op_stop(struct ieee80211_hw *hw)
        struct b43legacy_wl *wl = hw_to_b43legacy_wl(hw);
        struct b43legacy_wldev *dev = wl->current_dev;
 
-       b43legacy_rfkill_exit(dev);
        cancel_work_sync(&(wl->beacon_update_trigger));
 
        mutex_lock(&wl->mutex);
@@ -3518,6 +3508,7 @@ static const struct ieee80211_ops b43legacy_hw_ops = {
        .start                  = b43legacy_op_start,
        .stop                   = b43legacy_op_stop,
        .set_tim                = b43legacy_op_beacon_set_tim,
+       .rfkill_poll            = b43legacy_rfkill_poll,
 };
 
 /* Hard-reset the chip. Do not call this directly.
index c6230a64505a050d6ccf92f9229c09e5b71588d4..8783022db11e43e24ae12a641bd040a5aea38b07 100644 (file)
 
 */
 
-#include "rfkill.h"
 #include "radio.h"
 #include "b43legacy.h"
 
-#include <linux/kmod.h>
-
 
 /* Returns TRUE, if the radio is enabled in hardware. */
-static bool b43legacy_is_hw_radio_enabled(struct b43legacy_wldev *dev)
+bool b43legacy_is_hw_radio_enabled(struct b43legacy_wldev *dev)
 {
        if (dev->phy.rev >= 3) {
                if (!(b43legacy_read32(dev, B43legacy_MMIO_RADIO_HWENABLED_HI)
@@ -45,23 +42,31 @@ static bool b43legacy_is_hw_radio_enabled(struct b43legacy_wldev *dev)
 }
 
 /* The poll callback for the hardware button. */
-static void b43legacy_rfkill_poll(struct rfkill *rfkill, void *data)
+void b43legacy_rfkill_poll(struct ieee80211_hw *hw)
 {
-       struct b43legacy_wldev *dev = data;
-       struct b43legacy_wl *wl = dev->wl;
+       struct b43legacy_wl *wl = hw_to_b43legacy_wl(hw);
+       struct b43legacy_wldev *dev = wl->current_dev;
+       struct ssb_bus *bus = dev->dev->bus;
        bool enabled;
+       bool brought_up = false;
 
        mutex_lock(&wl->mutex);
        if (unlikely(b43legacy_status(dev) < B43legacy_STAT_INITIALIZED)) {
-               mutex_unlock(&wl->mutex);
-               return;
+               if (ssb_bus_powerup(bus, 0)) {
+                       mutex_unlock(&wl->mutex);
+                       return;
+               }
+               ssb_device_enable(dev->dev, 0);
+               brought_up = true;
        }
+
        enabled = b43legacy_is_hw_radio_enabled(dev);
+
        if (unlikely(enabled != dev->radio_hw_enable)) {
                dev->radio_hw_enable = enabled;
                b43legacyinfo(wl, "Radio hardware status changed to %s\n",
                        enabled ? "ENABLED" : "DISABLED");
-               enabled = !rfkill_set_hw_state(rfkill, !enabled);
+               wiphy_rfkill_set_hw_state(hw->wiphy, !enabled);
                if (enabled != dev->phy.radio_on) {
                        if (enabled)
                                b43legacy_radio_turn_on(dev);
@@ -69,95 +74,11 @@ static void b43legacy_rfkill_poll(struct rfkill *rfkill, void *data)
                                b43legacy_radio_turn_off(dev, 0);
                }
        }
-       mutex_unlock(&wl->mutex);
-}
-
-/* Called when the RFKILL toggled in software.
- * This is called without locking. */
-static int b43legacy_rfkill_soft_set(void *data, bool blocked)
-{
-       struct b43legacy_wldev *dev = data;
-       struct b43legacy_wl *wl = dev->wl;
-       int ret = -EINVAL;
 
-       if (!wl->rfkill.registered)
-               return -EINVAL;
-
-       mutex_lock(&wl->mutex);
-       if (b43legacy_status(dev) < B43legacy_STAT_INITIALIZED)
-               goto out_unlock;
-
-       if (!dev->radio_hw_enable)
-               goto out_unlock;
-
-       if (!blocked != dev->phy.radio_on) {
-               if (!blocked)
-                       b43legacy_radio_turn_on(dev);
-               else
-                       b43legacy_radio_turn_off(dev, 0);
+       if (brought_up) {
+               ssb_device_disable(dev->dev, 0);
+               ssb_bus_may_powerdown(bus);
        }
-       ret = 0;
 
-out_unlock:
        mutex_unlock(&wl->mutex);
-       return ret;
-}
-
-const char *b43legacy_rfkill_led_name(struct b43legacy_wldev *dev)
-{
-       struct b43legacy_rfkill *rfk = &(dev->wl->rfkill);
-
-       if (!rfk->registered)
-               return NULL;
-       return rfkill_get_led_trigger_name(rfk->rfkill);
 }
-
-static const struct rfkill_ops b43legacy_rfkill_ops = {
-       .set_block = b43legacy_rfkill_soft_set,
-       .poll = b43legacy_rfkill_poll,
-};
-
-void b43legacy_rfkill_init(struct b43legacy_wldev *dev)
-{
-       struct b43legacy_wl *wl = dev->wl;
-       struct b43legacy_rfkill *rfk = &(wl->rfkill);
-       int err;
-
-       rfk->registered = 0;
-
-       snprintf(rfk->name, sizeof(rfk->name),
-                "b43legacy-%s", wiphy_name(wl->hw->wiphy));
-       rfk->rfkill = rfkill_alloc(rfk->name,
-                                  dev->dev->dev,
-                                  RFKILL_TYPE_WLAN,
-                                  &b43legacy_rfkill_ops, dev);
-       if (!rfk->rfkill)
-               goto out_error;
-
-       err = rfkill_register(rfk->rfkill);
-       if (err)
-               goto err_free;
-
-       rfk->registered = 1;
-
-       return;
- err_free:
-       rfkill_destroy(rfk->rfkill);
- out_error:
-       rfk->registered = 0;
-       b43legacywarn(wl, "RF-kill button init failed\n");
-}
-
-void b43legacy_rfkill_exit(struct b43legacy_wldev *dev)
-{
-       struct b43legacy_rfkill *rfk = &(dev->wl->rfkill);
-
-       if (!rfk->registered)
-               return;
-       rfk->registered = 0;
-
-       rfkill_unregister(rfk->rfkill);
-       rfkill_destroy(rfk->rfkill);
-       rfk->rfkill = NULL;
-}
-
index adffc503a6a191fe2192995cba18159e8a894cd7..75585571c544872a3f476222aa16161879ad206d 100644 (file)
@@ -1,55 +1,11 @@
 #ifndef B43legacy_RFKILL_H_
 #define B43legacy_RFKILL_H_
 
+struct ieee80211_hw;
 struct b43legacy_wldev;
 
-#ifdef CONFIG_B43LEGACY_RFKILL
+void b43legacy_rfkill_poll(struct ieee80211_hw *hw);
 
-#include <linux/rfkill.h>
-
-
-
-struct b43legacy_rfkill {
-       /* The RFKILL subsystem data structure */
-       struct rfkill *rfkill;
-       /* Did initialization succeed? Used for freeing. */
-       bool registered;
-       /* The unique name of this rfkill switch */
-       char name[sizeof("b43legacy-phy4294967295")];
-};
-
-/* The init function returns void, because we are not interested
- * in failing the b43 init process when rfkill init failed. */
-void b43legacy_rfkill_init(struct b43legacy_wldev *dev);
-void b43legacy_rfkill_exit(struct b43legacy_wldev *dev);
-
-const char *b43legacy_rfkill_led_name(struct b43legacy_wldev *dev);
-
-
-#else /* CONFIG_B43LEGACY_RFKILL */
-/* No RFKILL support. */
-
-struct b43legacy_rfkill {
-       /* empty */
-};
-
-static inline void b43legacy_rfkill_alloc(struct b43legacy_wldev *dev)
-{
-}
-static inline void b43legacy_rfkill_free(struct b43legacy_wldev *dev)
-{
-}
-static inline void b43legacy_rfkill_init(struct b43legacy_wldev *dev)
-{
-}
-static inline void b43legacy_rfkill_exit(struct b43legacy_wldev *dev)
-{
-}
-static inline char *b43legacy_rfkill_led_name(struct b43legacy_wldev *dev)
-{
-       return NULL;
-}
-
-#endif /* CONFIG_B43LEGACY_RFKILL */
+bool b43legacy_is_hw_radio_enabled(struct b43legacy_wldev *dev);
 
 #endif /* B43legacy_RFKILL_H_ */