[PATCH] x86_64: another mb() for smpboot.c
authorBenjamin LaHaise <bcrl@kvack.org>
Wed, 11 Jan 2006 21:43:03 +0000 (22:43 +0100)
committerLinus Torvalds <torvalds@g5.osdl.org>
Thu, 12 Jan 2006 03:01:56 +0000 (19:01 -0800)
The following is probably a good idea given that the atomic_set() isn't
a barrier here either.

Signed-off-by: Benjamin LaHaise <benjamin.c.lahaise@intel.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
arch/x86_64/kernel/smpboot.c

index 043b1d262a3051bd0fcdea03f15d6c80838234bc..f513dacc177f82224745344b1bd335bc27dc5a18 100644 (file)
@@ -646,6 +646,7 @@ static int __cpuinit wakeup_secondary_via_INIT(int phys_apicid, unsigned int sta
                send_status = apic_read(APIC_ICR) & APIC_ICR_BUSY;
        } while (send_status && (timeout++ < 1000));
 
+       mb();
        atomic_set(&init_deasserted, 1);
 
        num_starts = 2;