drm/i915: Drop check for non-NULL entry in llist_for_each_entry_safe
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 30 May 2019 08:23:58 +0000 (09:23 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 31 May 2019 08:00:49 +0000 (09:00 +0100)
Since the next entry is an offset from a pointer, it can not be NULL.
For simplicity, drop the extra conditional before calling cond_resched()

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190530082358.13663-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gem/i915_gem_object.c

index f064876f1214842f4c347773111d0b80587351d1..55e79fdb81aa9b71c07326f66053093cb1bf9027 100644 (file)
@@ -248,8 +248,7 @@ static void __i915_gem_free_objects(struct drm_i915_private *i915,
                GEM_BUG_ON(!atomic_read(&i915->mm.free_count));
                atomic_dec(&i915->mm.free_count);
 
-               if (on)
-                       cond_resched();
+               cond_resched();
        }
        intel_runtime_pm_put(i915, wakeref);
 }