ASoC: Mediatek: MT8183: Fix build err while CONFIG_I2C set to module
authorYueHaibing <yuehaibing@huawei.com>
Wed, 17 Apr 2019 15:29:32 +0000 (23:29 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 2 May 2019 01:45:59 +0000 (10:45 +0900)
During randconfig builds, I occasionally run into an invalid configuration

WARNING: unmet direct dependencies detected for SND_SOC_TS3A227E
  Depends on [m]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=m]
  Selected by [y]:
  - SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_MT8183 [=y]

sound/soc/codecs/ts3a227e.o: In function `ts3a227e_i2c_probe':
ts3a227e.c:(.text+0x684): undefined reference to `__devm_regmap_init_i2c'
sound/soc/codecs/ts3a227e.o: In function `ts3a227e_driver_init':
ts3a227e.c:(.init.text+0x18): undefined reference to `i2c_register_driver'
sound/soc/codecs/ts3a227e.o: In function `ts3a227e_driver_exit':
ts3a227e.c:(.exit.text+0x14): undefined reference to `i2c_del_driver'

This patch add I2C dependency to fix this.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: ebbddc75bbe8 ("ASoC: Mediatek: MT8183: Add machine driver with DA7219")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mediatek/Kconfig

index 874404bcccfd904ecbaec6fc1b7ff52d051fb244..f70b7109f2b6bc68abb40828089d843b23b28b6e 100644 (file)
@@ -118,6 +118,7 @@ config SND_SOC_MT8183
 
 config SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A
        tristate "ASoC Audio driver for MT8183 with MT6358 TS3A227E MAX98357A codec"
+       depends on I2C
        depends on SND_SOC_MT8183
        select SND_SOC_MT6358
        select SND_SOC_MAX98357A