pinctrl: ocelot: fix gpio direction for pins after 31
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 20 Jun 2019 18:30:36 +0000 (20:30 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 25 Jun 2019 13:41:41 +0000 (15:41 +0200)
The third argument passed to REG is not the correct one and
ocelot_gpio_set_direction is not working for pins after 31. Fix that by
passing the pin number instead of the modulo 32 value.

Fixes: da801ab56ad8 pinctrl: ocelot: add MSCC Jaguar2 support
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-ocelot.c

index 3b4ca52d2456f72b85638ea88394e5c92b02f7bd..d2478db975bde171b82637ebfab59a942d7e1e04 100644 (file)
@@ -432,7 +432,7 @@ static int ocelot_gpio_set_direction(struct pinctrl_dev *pctldev,
        struct ocelot_pinctrl *info = pinctrl_dev_get_drvdata(pctldev);
        unsigned int p = pin % 32;
 
-       regmap_update_bits(info->map, REG(OCELOT_GPIO_OE, info, p), BIT(p),
+       regmap_update_bits(info->map, REG(OCELOT_GPIO_OE, info, pin), BIT(p),
                           input ? 0 : BIT(p));
 
        return 0;