luci-proto-qmi: only show password and username if auth is selected 2792/head
authorFlorian Eckert <fe@dev.tdt.de>
Wed, 26 Jun 2019 11:04:47 +0000 (13:04 +0200)
committerFlorian Eckert <fe@dev.tdt.de>
Wed, 26 Jun 2019 11:08:23 +0000 (13:08 +0200)
Only show username and password if we use PAP/CHAP, PAP or CHAP
authentication.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
protocols/luci-proto-qmi/luasrc/model/cbi/admin_network/proto_qmi.lua

index a7a1c67279f5b4ae739686cf487bb7c4f520eb35..9cc1ae0cf583ad51e584b784d24ba9fdf8a73a05 100644 (file)
@@ -26,18 +26,26 @@ apn = section:taboption("general", Value, "apn", translate("APN"))
 pincode = section:taboption("general", Value, "pincode", translate("PIN"))
 
 
+auth = section:taboption("general", Value, "auth", translate("Authentication Type"))
+auth:value("both", "PAP/CHAP (both)")
+auth:value("pap", "PAP")
+auth:value("chap", "CHAP")
+auth:value("none", "NONE")
+auth.default = "none"
+
+
 username = section:taboption("general", Value, "username", translate("PAP/CHAP username"))
+username:depends("auth", "pap")
+username:depends("auth", "chap")
+username:depends("auth", "both")
 
 
 password = section:taboption("general", Value, "password", translate("PAP/CHAP password"))
+password:depends("auth", "pap")
+password:depends("auth", "chap")
+password:depends("auth", "both")
 password.password = true
 
-auth = section:taboption("general", Value, "auth", translate("Authentication Type"))
-auth:value("", translate("-- Please choose --"))
-auth:value("both", "PAP/CHAP (both)")
-auth:value("pap", "PAP")
-auth:value("chap", "CHAP")
-auth:value("none", "NONE")
 
 if luci.model.network:has_ipv6() then
     ipv6 = section:taboption("advanced", Flag, "ipv6", translate("Enable IPv6 negotiation"))