i40e: hold the RTNL lock while changing interrupt schemes

When we suspend and resume, we need to clear and re-enable the interrupt
scheme. This was previously not done while holding the RTNL lock, which
could be problematic, because we are actually destroying and re-creating
queues.

Hold the RTNL lock for the entire sequence of preparing for reset, and
when resuming. This additionally protects the flags related to interrupt
scheme under RTNL lock so that their modification is properly threaded.

This is part of a larger effort to remove the need for cmpxchg64 in
i40e_set_priv_flags().

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 68b51761c50968b9a71ca0b10dbfb3a64d411ebe..5efd6d7bfa59fb6a39dab67d99f1f49774790293 100644 (file)
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -14348,7 +14348,13 @@ static int __maybe_unused i40e_suspend(struct device *dev)
        if (pf->wol_en && (pf->hw_features & I40E_HW_WOL_MC_MAGIC_PKT_WAKE))
                i40e_enable_mc_magic_wake(pf);
 
-       i40e_prep_for_reset(pf, false);
+       /* Since we're going to destroy queues during the
+        * i40e_clear_interrupt_scheme() we should hold the RTNL lock for this
+        * whole section
+        */
+       rtnl_lock();
+
+       i40e_prep_for_reset(pf, true);
 
        wr32(hw, I40E_PFPM_APM, (pf->wol_en ? I40E_PFPM_APM_APME_MASK : 0));
        wr32(hw, I40E_PFPM_WUFC, (pf->wol_en ? I40E_PFPM_WUFC_MAG_MASK : 0));
@@ -14360,6 +14366,8 @@ static int __maybe_unused i40e_suspend(struct device *dev)
         */
        i40e_clear_interrupt_scheme(pf);
 
+       rtnl_unlock();
+
        return 0;
 }
 
@@ -14377,6 +14385,11 @@ static int __maybe_unused i40e_resume(struct device *dev)
        if (!test_bit(__I40E_SUSPENDED, pf->state))
                return 0;
 
+       /* We need to hold the RTNL lock prior to restoring interrupt schemes,
+        * since we're going to be restoring queues
+        */
+       rtnl_lock();
+
        /* We cleared the interrupt scheme when we suspended, so we need to
         * restore it now to resume device functionality.
         */
@@ -14387,7 +14400,9 @@ static int __maybe_unused i40e_resume(struct device *dev)
        }
 
        clear_bit(__I40E_DOWN, pf->state);
-       i40e_reset_and_rebuild(pf, false, false);
+       i40e_reset_and_rebuild(pf, false, true);
+
+       rtnl_unlock();
 
        /* Clear suspended state last after everything is recovered */
        clear_bit(__I40E_SUSPENDED, pf->state);