projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
abbe3ac
)
Input: atmel_mxt_ts - fix leak in mxt_update_cfg()
author
Ian Ray
<ian.ray@ge.com>
Thu, 4 Jul 2019 23:13:25 +0000
(16:13 -0700)
committer
Dmitry Torokhov
<dmitry.torokhov@gmail.com>
Fri, 5 Jul 2019 17:17:07 +0000
(10:17 -0700)
Fix leak (whose magnitude is the configuration file size) when the CRCs
match in mxt_update_cfg().
Signed-off-by: Ian Ray <ian.ray@ge.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/atmel_mxt_ts.c
patch
|
blob
|
history
diff --git
a/drivers/input/touchscreen/atmel_mxt_ts.c
b/drivers/input/touchscreen/atmel_mxt_ts.c
index 5c63d25ce84ebee9a6296de142c8cd6115a79701..8b536778f1d8ecebe0cc30939fc02dc2cc243ef8 100644
(file)
--- a/
drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/
drivers/input/touchscreen/atmel_mxt_ts.c
@@
-1526,7
+1526,8
@@
static int mxt_update_cfg(struct mxt_data *data, const struct firmware *fw)
} else if (config_crc == data->config_crc) {
dev_dbg(dev, "Config CRC 0x%06X: OK\n",
data->config_crc);
- return 0;
+ ret = 0;
+ goto release_raw;
} else {
dev_info(dev, "Config CRC 0x%06X: does not match file 0x%06X\n",
data->config_crc, config_crc);