drm/nouveau/therm: skip probing for devices not specified in thermal tables
authorBen Skeggs <bskeggs@redhat.com>
Tue, 2 Jul 2019 02:52:11 +0000 (12:52 +1000)
committerBen Skeggs <bskeggs@redhat.com>
Fri, 23 Aug 2019 02:55:33 +0000 (12:55 +1000)
Saves some time during driver load, as described by the relevant section[1]
of the DCB 4.x specification.

[1] https://nvidia.github.io/open-gpu-doc/DCB/DCB-4.x-Specification.html#_i2c_device_table

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/extdev.h
drivers/gpu/drm/nouveau/nvkm/subdev/bios/extdev.c
drivers/gpu/drm/nouveau/nvkm/subdev/therm/ic.c

index f29f2d8da142bf0b4a5917018b69f7ef8b10760f..9ac3dda4b44f079462933be03fbcd5c92574b101 100644 (file)
@@ -26,4 +26,6 @@ nvbios_extdev_parse(struct nvkm_bios *, int, struct nvbios_extdev_func *);
 int
 nvbios_extdev_find(struct nvkm_bios *, enum nvbios_extdev_type,
                   struct nvbios_extdev_func *);
+
+bool nvbios_extdev_skip_probe(struct nvkm_bios *);
 #endif
index b8578359e61bc4c17d79a4c0f4b96404ff365823..118e33174cbed165cc1ddb7fef96715c715ae9d7 100644 (file)
@@ -46,6 +46,19 @@ extdev_table(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *len, u8 *cnt)
        return extdev + *hdr;
 }
 
+bool
+nvbios_extdev_skip_probe(struct nvkm_bios *bios)
+{
+       u8  ver, hdr, len, cnt;
+       u16 data = extdev_table(bios, &ver, &hdr, &len, &cnt);
+       if (data && ver == 0x40 && hdr >= 5) {
+               u8 flags = nvbios_rd08(bios, data - hdr + 4);
+               if (flags & 1)
+                       return true;
+       }
+       return false;
+}
+
 static u16
 nvbios_extdev_entry(struct nvkm_bios *bios, int idx, u8 *ver, u8 *len)
 {
index 6e0ddc1bb583541af27d90e3029805cb231c7ad1..03b355dabab3dc64507e3102259b1fd6451972ba 100644 (file)
@@ -116,6 +116,9 @@ nvkm_therm_ic_ctor(struct nvkm_therm *therm)
                        return;
        }
 
+       if (nvbios_extdev_skip_probe(bios))
+               return;
+
        /* The vbios doesn't provide the address of an exisiting monitoring
           device. Let's try our static list.
         */