ASoC: rt298: fix boolean tests
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Sat, 5 Jan 2019 02:02:36 +0000 (20:02 -0600)
committerMark Brown <broonie@kernel.org>
Mon, 7 Jan 2019 16:54:34 +0000 (16:54 +0000)
Reported by Coccinelle:

sound/soc/codecs/rt298.c:992:6-8: WARNING: Comparison to bool
sound/soc/codecs/rt298.c:995:6-9: WARNING: Comparison to bool
sound/soc/codecs/rt298.c:317:5-7: WARNING: Comparison to bool
sound/soc/codecs/rt298.c:320:5-8: WARNING: Comparison to bool
sound/soc/codecs/rt298.c:348:5-7: WARNING: Comparison to bool
sound/soc/codecs/rt298.c:351:5-8: WARNING: Comparison to bool

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt298.c

index 06cdba4edfe2cdf5accc6ad54f82efbfe1d5eaa8..bcf5bab3196916164976cad1fb410d024d6b5ab5 100644 (file)
@@ -314,10 +314,10 @@ static void rt298_jack_detect_work(struct work_struct *work)
        if (rt298_jack_detect(rt298, &hp, &mic) < 0)
                return;
 
-       if (hp == true)
+       if (hp)
                status |= SND_JACK_HEADPHONE;
 
-       if (mic == true)
+       if (mic)
                status |= SND_JACK_MICROPHONE;
 
        snd_soc_jack_report(rt298->jack, status,
@@ -345,10 +345,10 @@ int rt298_mic_detect(struct snd_soc_component *component, struct snd_soc_jack *j
        regmap_update_bits(rt298->regmap, RT298_IRQ_CTRL, 0x2, 0x2);
 
        rt298_jack_detect(rt298, &hp, &mic);
-       if (hp == true)
+       if (hp)
                status |= SND_JACK_HEADPHONE;
 
-       if (mic == true)
+       if (mic)
                status |= SND_JACK_MICROPHONE;
 
        snd_soc_jack_report(rt298->jack, status,
@@ -989,10 +989,10 @@ static irqreturn_t rt298_irq(int irq, void *data)
        regmap_update_bits(rt298->regmap, RT298_IRQ_CTRL, 0x1, 0x1);
 
        if (ret == 0) {
-               if (hp == true)
+               if (hp)
                        status |= SND_JACK_HEADPHONE;
 
-               if (mic == true)
+               if (mic)
                        status |= SND_JACK_MICROPHONE;
 
                snd_soc_jack_report(rt298->jack, status,