CIFS: Do not hide EINTR after sending network packets
authorPavel Shilovsky <pshilov@microsoft.com>
Thu, 10 Jan 2019 19:27:28 +0000 (11:27 -0800)
committerSteve French <stfrench@microsoft.com>
Fri, 11 Jan 2019 13:13:05 +0000 (07:13 -0600)
Currently we hide EINTR code returned from sock_sendmsg()
and return 0 instead. This makes a caller think that we
successfully completed the network operation which is not
true. Fix this by properly returning EINTR to callers.

Cc: <stable@vger.kernel.org>
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/transport.c

index e047f06c9b4fb78223a1e8b01d5abb9636de9aaf..aaff9c5aab3d0ea77c38a5d4678d1669b0f2d10c 100644 (file)
@@ -387,7 +387,7 @@ smbd_done:
        if (rc < 0 && rc != -EINTR)
                cifs_dbg(VFS, "Error %d sending data on socket to server\n",
                         rc);
-       else
+       else if (rc > 0)
                rc = 0;
 
        return rc;