mlxsw: spectrum: Don't create FIDs upon creation of VLAN uppers

Up until now we used to create FIDs upon the creation of VLAN uppers on
top of the VLAN-aware bridge. This was done so that in case a router
interface (RIF) was configured on top of the bridge, the FID would
already be there.

Instead, simplify the code and only create the FID upon RIF creation.

This is an intermediary step towards the introduction of the common FID
core, in which this code would be completely removed.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
index 29d9439f6f12d58a5739713a54d7afadafd5bffd..f4c31f668e8d0e0b1f0ca43cbc040574a880b7a4 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
@@ -3982,17 +3982,6 @@ int mlxsw_sp_port_fdb_flush(struct mlxsw_sp_port *mlxsw_sp_port, u16 fid)
                return mlxsw_sp_port_fdb_flush_by_port_fid(mlxsw_sp_port, fid);
 }
 
-static void mlxsw_sp_master_bridge_gone_sync(struct mlxsw_sp *mlxsw_sp)
-{
-       struct mlxsw_sp_fid *f, *tmp;
-
-       list_for_each_entry_safe(f, tmp, &mlxsw_sp->fids, list)
-               if (--f->ref_count == 0)
-                       mlxsw_sp_fid_destroy(mlxsw_sp, f);
-               else
-                       WARN_ON_ONCE(1);
-}
-
 static bool mlxsw_sp_master_bridge_check(struct mlxsw_sp *mlxsw_sp,
                                         struct net_device *br_dev)
 {
@@ -4014,15 +4003,8 @@ static void mlxsw_sp_master_bridge_dec(struct mlxsw_sp *mlxsw_sp)
 {
        struct mlxsw_sp_upper *master_bridge = mlxsw_sp_master_bridge(mlxsw_sp);
 
-       if (--master_bridge->ref_count == 0) {
+       if (--master_bridge->ref_count == 0)
                master_bridge->dev = NULL;
-               /* It's possible upper VLAN devices are still holding
-                * references to underlying FIDs. Drop the reference
-                * and release the resources if it was the last one.
-                * If it wasn't, then something bad happened.
-                */
-               mlxsw_sp_master_bridge_gone_sync(mlxsw_sp);
-       }
 }
 
 static int mlxsw_sp_port_bridge_join(struct mlxsw_sp_port *mlxsw_sp_port,
@@ -4584,79 +4566,6 @@ static int mlxsw_sp_netdevice_lag_event(struct net_device *lag_dev,
        return 0;
 }
 
-static int mlxsw_sp_master_bridge_vlan_link(struct mlxsw_sp *mlxsw_sp,
-                                           struct net_device *vlan_dev)
-{
-       u16 fid = vlan_dev_vlan_id(vlan_dev);
-       struct mlxsw_sp_fid *f;
-
-       f = mlxsw_sp_fid_find(mlxsw_sp, fid);
-       if (!f) {
-               f = mlxsw_sp_fid_create(mlxsw_sp, fid);
-               if (IS_ERR(f))
-                       return PTR_ERR(f);
-       }
-
-       f->ref_count++;
-
-       return 0;
-}
-
-static void mlxsw_sp_master_bridge_vlan_unlink(struct mlxsw_sp *mlxsw_sp,
-                                              struct net_device *vlan_dev)
-{
-       u16 fid = vlan_dev_vlan_id(vlan_dev);
-       struct mlxsw_sp_fid *f;
-
-       f = mlxsw_sp_fid_find(mlxsw_sp, fid);
-       if (f && f->rif)
-               mlxsw_sp_rif_bridge_destroy(mlxsw_sp, f->rif);
-       if (f && --f->ref_count == 0)
-               mlxsw_sp_fid_destroy(mlxsw_sp, f);
-}
-
-static int mlxsw_sp_netdevice_bridge_event(struct net_device *br_dev,
-                                          unsigned long event, void *ptr)
-{
-       struct netdev_notifier_changeupper_info *info;
-       struct net_device *upper_dev;
-       struct mlxsw_sp *mlxsw_sp;
-       int err = 0;
-
-       mlxsw_sp = mlxsw_sp_lower_get(br_dev);
-       if (!mlxsw_sp)
-               return 0;
-
-       info = ptr;
-
-       switch (event) {
-       case NETDEV_PRECHANGEUPPER:
-               upper_dev = info->upper_dev;
-               if (!is_vlan_dev(upper_dev))
-                       return -EINVAL;
-               if (is_vlan_dev(upper_dev) &&
-                   br_dev != mlxsw_sp_master_bridge(mlxsw_sp)->dev)
-                       return -EINVAL;
-               break;
-       case NETDEV_CHANGEUPPER:
-               upper_dev = info->upper_dev;
-               if (is_vlan_dev(upper_dev)) {
-                       if (info->linking)
-                               err = mlxsw_sp_master_bridge_vlan_link(mlxsw_sp,
-                                                                      upper_dev);
-                       else
-                               mlxsw_sp_master_bridge_vlan_unlink(mlxsw_sp,
-                                                                  upper_dev);
-               } else {
-                       err = -EINVAL;
-                       WARN_ON(1);
-               }
-               break;
-       }
-
-       return err;
-}
-
 static u16 mlxsw_sp_avail_vfid_get(const struct mlxsw_sp *mlxsw_sp)
 {
        return find_first_zero_bit(mlxsw_sp->vfids.mapped,
@@ -5012,8 +4921,6 @@ static int mlxsw_sp_netdevice_event(struct notifier_block *unused,
                err = mlxsw_sp_netdevice_port_event(dev, dev, event, ptr);
        else if (netif_is_lag_master(dev))
                err = mlxsw_sp_netdevice_lag_event(dev, event, ptr);
-       else if (netif_is_bridge_master(dev))
-               err = mlxsw_sp_netdevice_bridge_event(dev, event, ptr);
        else if (is_vlan_dev(dev))
                err = mlxsw_sp_netdevice_vlan_event(dev, event, ptr);
 

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index ef8e8a12c001391c60acfbe7769053a285925e9f..c582180e935438e3b9175e544d258da194eb28a5 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -3239,16 +3239,24 @@ static int mlxsw_sp_inetaddr_lag_event(struct net_device *lag_dev,
 static struct mlxsw_sp_fid *mlxsw_sp_bridge_fid_get(struct mlxsw_sp *mlxsw_sp,
                                                    struct net_device *l3_dev)
 {
-       u16 fid;
+       struct mlxsw_sp_fid *fid;
+       u16 fid_index;
 
        if (is_vlan_dev(l3_dev))
-               fid = vlan_dev_vlan_id(l3_dev);
+               fid_index = vlan_dev_vlan_id(l3_dev);
        else if (mlxsw_sp_master_bridge(mlxsw_sp)->dev == l3_dev)
-               fid = 1;
+               fid_index = 1;
        else
                return mlxsw_sp_vfid_find(mlxsw_sp, l3_dev);
 
-       return mlxsw_sp_fid_find(mlxsw_sp, fid);
+       fid = mlxsw_sp_fid_find(mlxsw_sp, fid_index);
+       if (fid)
+               return fid;
+
+       fid = mlxsw_sp_fid_create(mlxsw_sp, fid_index);
+       if (IS_ERR(fid))
+               return NULL;
+       return fid;
 }
 
 static u8 mlxsw_sp_router_port(const struct mlxsw_sp *mlxsw_sp)