media: lm3646: remove redundant assignment to variable rval

The variable rval is being initialized with a value that
is never read and is being re-assigned a little later on. The
assignment is redundant and hence can be removed.

Addresses-Coverity: ("Unused value")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

diff --git a/drivers/media/i2c/lm3646.c b/drivers/media/i2c/lm3646.c
index d8a8853f9a2baf65225d74ee3d8327394375bf72..c76ccf67a9094e411d8b5dc54e65e0bc67f17839 100644 (file)
--- a/drivers/media/i2c/lm3646.c
+++ b/drivers/media/i2c/lm3646.c
@@ -134,7 +134,7 @@ static int lm3646_set_ctrl(struct v4l2_ctrl *ctrl)
 {
        struct lm3646_flash *flash = to_lm3646_flash(ctrl);
        unsigned int reg_val;
-       int rval = -EINVAL;
+       int rval;
 
        switch (ctrl->id) {
        case V4L2_CID_FLASH_LED_MODE: