Bluetooth: Fix faulty expression for minimum encryption key size check
authorMatias Karhumaa <matias.karhumaa@gmail.com>
Tue, 2 Jul 2019 14:35:09 +0000 (16:35 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 3 Jul 2019 08:09:09 +0000 (16:09 +0800)
Fix minimum encryption key size check so that HCI_MIN_ENC_KEY_SIZE is
also allowed as stated in the comment.

This bug caused connection problems with devices having maximum
encryption key size of 7 octets (56-bit).

Fixes: 693cd8ce3f88 ("Bluetooth: Fix regression with minimum encryption key size alignment")
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=203997
Signed-off-by: Matias Karhumaa <matias.karhumaa@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
net/bluetooth/l2cap_core.c

index 9f77432dbe38a07256f4956692c7d86b82e983db..5406d7cd46ad19592af6ea2db381a5c511568201 100644 (file)
@@ -1353,7 +1353,7 @@ static bool l2cap_check_enc_key_size(struct hci_conn *hcon)
         * actually encrypted before enforcing a key size.
         */
        return (!test_bit(HCI_CONN_ENCRYPT, &hcon->flags) ||
-               hcon->enc_key_size > HCI_MIN_ENC_KEY_SIZE);
+               hcon->enc_key_size >= HCI_MIN_ENC_KEY_SIZE);
 }
 
 static void l2cap_do_start(struct l2cap_chan *chan)