projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
ebd6e77
)
bcm63xx_enet: timeout off by one in do_mdio_op()
author
roel kluin
<roel.kluin@gmail.com>
Mon, 21 Sep 2009 10:08:48 +0000
(10:08 +0000)
committer
David S. Miller
<davem@davemloft.net>
Thu, 1 Oct 2009 03:03:15 +0000
(20:03 -0700)
`while (limit-- >= 0)' reaches -2 after the loop upon timeout.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Maxime Bizon <mbizon@freebox.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bcm63xx_enet.c
patch
|
blob
|
history
diff --git
a/drivers/net/bcm63xx_enet.c
b/drivers/net/bcm63xx_enet.c
index 09d270913c5041f866537f9e7c4ae6d3a3d976c8..ba29dc319b34860b651696b929b8af908b0b8428 100644
(file)
--- a/
drivers/net/bcm63xx_enet.c
+++ b/
drivers/net/bcm63xx_enet.c
@@
-90,7
+90,7
@@
static int do_mdio_op(struct bcm_enet_priv *priv, unsigned int data)
if (enet_readl(priv, ENET_IR_REG) & ENET_IR_MII)
break;
udelay(1);
- } while (limit-- >
=
0);
+ } while (limit-- > 0);
return (limit < 0) ? 1 : 0;
}