ravb: Do not announce HDX as supported
authorMagnus Damm <damm+renesas@opensource.se>
Wed, 21 Nov 2018 11:21:17 +0000 (20:21 +0900)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Nov 2018 19:14:47 +0000 (11:14 -0800)
According to the data sheet the Ethernet-AVB hardware in R-Car Gen3
and R-Car Gen2 SoCs do not support half duplex operation. So update
the driver to mark 100Mbit and 1Gbps HDX as unsupported.

Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/ravb_main.c

index defed0d0c51d33cf842b8e326fcde405dbfedb92..24ad493ec136f5343e5e9f866f6d59b560219498 100644 (file)
@@ -1088,6 +1088,10 @@ static int ravb_phy_init(struct net_device *ndev)
        phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_Pause_BIT);
        phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_Asym_Pause_BIT);
 
+       /* Half Duplex is not supported */
+       phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_1000baseT_Half_BIT);
+       phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_100baseT_Half_BIT);
+
        phy_attached_info(phydev);
 
        return 0;