drm: refuse ADDFB2 ioctl for broken bigendian drivers

Drivers must set the quirk_addfb_prefer_host_byte_order quirk to make
the drm_mode_addfb() compat code work correctly on bigendian machines.

If they don't they interpret pixel_format values incorrectly for bug
compatibility, which in turn implies the ADDFB2 ioctl does not work
correctly then.  So block it to make userspace fallback to ADDFB.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20180907073213.20410-1-kraxel@redhat.com

diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h
index ede20b55d50c565e6808622eeee2ce1c7f63cda6..86893448f4868a876a49e174b64a29d7514a4108 100644 (file)
--- a/drivers/gpu/drm/drm_crtc_internal.h
+++ b/drivers/gpu/drm/drm_crtc_internal.h
@@ -182,6 +182,8 @@ void drm_fb_release(struct drm_file *file_priv);
 
 int drm_mode_addfb(struct drm_device *dev, struct drm_mode_fb_cmd *or,
                   struct drm_file *file_priv);
+int drm_mode_addfb2(struct drm_device *dev,
+                   void *data, struct drm_file *file_priv);
 int drm_mode_rmfb(struct drm_device *dev, u32 fb_id,
                  struct drm_file *file_priv);
 
@@ -189,8 +191,8 @@ int drm_mode_rmfb(struct drm_device *dev, u32 fb_id,
 /* IOCTL */
 int drm_mode_addfb_ioctl(struct drm_device *dev,
                         void *data, struct drm_file *file_priv);
-int drm_mode_addfb2(struct drm_device *dev,
-                   void *data, struct drm_file *file_priv);
+int drm_mode_addfb2_ioctl(struct drm_device *dev,
+                         void *data, struct drm_file *file_priv);
 int drm_mode_rmfb_ioctl(struct drm_device *dev,
                        void *data, struct drm_file *file_priv);
 int drm_mode_getfb(struct drm_device *dev,

diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c
index 227f52e55d0530466a55490d7c753e49491314e5..6eaacd4eb8cc62f6c33c5bcbf440492f2766011a 100644 (file)
--- a/drivers/gpu/drm/drm_framebuffer.c
+++ b/drivers/gpu/drm/drm_framebuffer.c
@@ -369,6 +369,30 @@ int drm_mode_addfb2(struct drm_device *dev,
        return 0;
 }
 
+int drm_mode_addfb2_ioctl(struct drm_device *dev,
+                         void *data, struct drm_file *file_priv)
+{
+#ifdef __BIG_ENDIAN
+       if (!dev->mode_config.quirk_addfb_prefer_host_byte_order) {
+               /*
+                * Drivers must set the
+                * quirk_addfb_prefer_host_byte_order quirk to make
+                * the drm_mode_addfb() compat code work correctly on
+                * bigendian machines.
+                *
+                * If they don't they interpret pixel_format values
+                * incorrectly for bug compatibility, which in turn
+                * implies the ADDFB2 ioctl does not work correctly
+                * then.  So block it to make userspace fallback to
+                * ADDFB.
+                */
+               DRM_DEBUG_KMS("addfb2 broken on bigendian");
+               return -EINVAL;
+       }
+#endif
+       return drm_mode_addfb2(dev, data, file_priv);
+}
+
 struct drm_mode_rmfb_work {
        struct work_struct work;
        struct list_head fbs;

diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c
index ea10e9a26aadd5e8598e837ccd4375a15bfbe3dc..6b4a633b4240953f7ba7aa57692f9f954d2fd38c 100644 (file)
--- a/drivers/gpu/drm/drm_ioctl.c
+++ b/drivers/gpu/drm/drm_ioctl.c
@@ -645,7 +645,7 @@ static const struct drm_ioctl_desc drm_ioctls[] = {
        DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETPROPBLOB, drm_mode_getblob_ioctl, DRM_UNLOCKED),
        DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETFB, drm_mode_getfb, DRM_UNLOCKED),
        DRM_IOCTL_DEF(DRM_IOCTL_MODE_ADDFB, drm_mode_addfb_ioctl, DRM_UNLOCKED),
-       DRM_IOCTL_DEF(DRM_IOCTL_MODE_ADDFB2, drm_mode_addfb2, DRM_UNLOCKED),
+       DRM_IOCTL_DEF(DRM_IOCTL_MODE_ADDFB2, drm_mode_addfb2_ioctl, DRM_UNLOCKED),
        DRM_IOCTL_DEF(DRM_IOCTL_MODE_RMFB, drm_mode_rmfb_ioctl, DRM_UNLOCKED),
        DRM_IOCTL_DEF(DRM_IOCTL_MODE_PAGE_FLIP, drm_mode_page_flip_ioctl, DRM_MASTER|DRM_UNLOCKED),
        DRM_IOCTL_DEF(DRM_IOCTL_MODE_DIRTYFB, drm_mode_dirtyfb_ioctl, DRM_MASTER|DRM_UNLOCKED),