mac802154: iface: add validation for extended address
authorAlexander Aring <alex.aring@gmail.com>
Sun, 2 Nov 2014 03:18:46 +0000 (04:18 +0100)
committerMarcel Holtmann <marcel@holtmann.org>
Sun, 2 Nov 2014 03:51:08 +0000 (04:51 +0100)
This patch use the validation function to check if an extended address
is valid or not while set the extended address.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/mac802154/iface.c

index eaad66590f10bd223043e47fb39541adf2b98501..ceedf3ef1ce22a54fae397a1fa187259434620ca 100644 (file)
@@ -112,13 +112,17 @@ static int mac802154_wpan_mac_addr(struct net_device *dev, void *p)
 {
        struct ieee802154_sub_if_data *sdata = IEEE802154_DEV_TO_SUB_IF(dev);
        struct sockaddr *addr = p;
+       __le64 extended_addr;
 
        if (netif_running(dev))
                return -EBUSY;
 
-       /* FIXME: validate addr */
+       extended_addr = ieee802154_netdev_to_extended_addr(addr->sa_data);
+       if (!ieee802154_is_valid_extended_addr(extended_addr))
+               return -EINVAL;
+
        memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
-       sdata->extended_addr = ieee802154_netdev_to_extended_addr(dev->dev_addr);
+       sdata->extended_addr = extended_addr;
 
        return mac802154_wpan_update_llsec(dev);
 }