mtd: block2mtd: check device size
authorFabian Frederick <fabf@skynet.be>
Thu, 6 Mar 2014 10:04:22 +0000 (18:04 +0800)
committerBrian Norris <computersforpeace@gmail.com>
Tue, 11 Mar 2014 05:42:31 +0000 (22:42 -0700)
fixme applied : check device size is a multiple of erasesize.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
drivers/mtd/devices/block2mtd.c

index 3e12234b756595efc929f5d9741a2b3ef7a7fdb1..66f0405f7e535b33f02f71586ffe4bc13b5f1ee0 100644 (file)
@@ -209,7 +209,6 @@ static void block2mtd_free_device(struct block2mtd_dev *dev)
 }
 
 
-/* FIXME: ensure that mtd->size % erase_size == 0 */
 static struct block2mtd_dev *add_device(char *devname, int erase_size)
 {
        const fmode_t mode = FMODE_READ | FMODE_WRITE | FMODE_EXCL;
@@ -249,6 +248,11 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size)
                goto err_free_block2mtd;
        }
 
+       if ((long)dev->blkdev->bd_inode->i_size % erase_size) {
+               pr_err("erasesize must be a divisor of device size\n");
+               goto err_free_block2mtd;
+       }
+
        mutex_init(&dev->write_mutex);
 
        /* Setup the MTD structure */