[media] media/rc/imon.c: avoid flooding syslog with "unknown keypress" when keypad...

My 15c2:0036 device floods syslog when a keypad key is pressed:

	Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2
	Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fef2
	Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2
	Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2
	Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2

This patch removes those messages from imon, following suggestion from
Mauro. Unknown keys shall be correctly handled by rc/input layer.

Signed-off-by: Kevin Baradon <kevin.baradon@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c
index 178b94660b589a9309f08411200b126ed7520641..b8f9f85a11c92d03f0ecf90c1d2f76c3ba8f7a17 100644 (file)
--- a/drivers/media/rc/imon.c
+++ b/drivers/media/rc/imon.c
@@ -1573,11 +1573,6 @@ static void imon_incoming_packet(struct imon_context *ictx,
        if (press_type < 0)
                goto not_input_data;
 
-       spin_lock_irqsave(&ictx->kc_lock, flags);
-       if (ictx->kc == KEY_UNKNOWN)
-               goto unknown_key;
-       spin_unlock_irqrestore(&ictx->kc_lock, flags);
-
        if (ktype != IMON_KEY_PANEL) {
                if (press_type == 0)
                        rc_keyup(ictx->rdev);
@@ -1620,12 +1615,6 @@ static void imon_incoming_packet(struct imon_context *ictx,
 
        return;
 
-unknown_key:
-       spin_unlock_irqrestore(&ictx->kc_lock, flags);
-       dev_info(dev, "%s: unknown keypress, code 0x%llx\n", __func__,
-                (long long)scancode);
-       return;
-
 not_input_data:
        if (len != 8) {
                dev_warn(dev, "imon %s: invalid incoming packet "