amdgpu/dc: don't check for 0 on register read/writes always.
authorDave Airlie <airlied@redhat.com>
Thu, 28 Sep 2017 02:42:01 +0000 (12:42 +1000)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 28 Sep 2017 20:52:39 +0000 (16:52 -0400)
This adds ~50k to the driver text segment, and 10k to data segment.

   text    data     bss     dec     hex filename
2385556   39681    1045 2426282  2505aa drivers/gpu/drm/amd/amdgpu/amdgpu.o
  text    data     bss     dec     hex filename
2336593   28857    1045 2366495  241c1f drivers/gpu/drm/amd/amdgpu/amdgpu.o

Signed-off-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dm_services.h

index 8ab0af6f4c6b36040cf5b49673d1ef8f77a0d160..c976e2aa10e0b07b60ad81bdce247f98a82c4a21 100644 (file)
@@ -96,6 +96,9 @@ irq_handler_idx dm_register_interrupt(
  *
  */
 
+/* enable for debugging new code, this adds 50k to the driver size. */
+/* #define DM_CHECK_ADDR_0 */
+
 #define dm_read_reg(ctx, address)      \
                dm_read_reg_func(ctx, address, __func__)
 
@@ -105,12 +108,12 @@ static inline uint32_t dm_read_reg_func(
        const char *func_name)
 {
        uint32_t value;
-
+#ifdef DM_CHECK_ADDR_0
        if (address == 0) {
                DC_ERR("invalid register read; address = 0\n");
                return 0;
        }
-
+#endif
        value = cgs_read_register(ctx->cgs_device, address);
 
        return value;
@@ -125,10 +128,12 @@ static inline void dm_write_reg_func(
        uint32_t value,
        const char *func_name)
 {
+#ifdef DM_CHECK_ADDR_0
        if (address == 0) {
                DC_ERR("invalid register write. address = 0");
                return;
        }
+#endif
        cgs_write_register(ctx->cgs_device, address, value);
 }