drm/sti: Replace 17 seq_puts() calls by seq_putc()

Single characters should be put into a sequence at several places.
Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Link: http://patchwork.freedesktop.org/patch/msgid/5b4e2964-0742-8367-976f-678356d9347a@users.sourceforge.net

diff --git a/drivers/gpu/drm/sti/sti_cursor.c b/drivers/gpu/drm/sti/sti_cursor.c
index cca75bddb9ad1aa6d77cc317bfb3d56f36c79c6b..cd35b9d9de26f758e49e389c19d8e28497981e3c 100644 (file)
--- a/drivers/gpu/drm/sti/sti_cursor.c
+++ b/drivers/gpu/drm/sti/sti_cursor.c
@@ -121,8 +121,7 @@ static int cursor_dbg_show(struct seq_file *s, void *data)
        cursor_dbg_cml(s, cursor, readl(cursor->regs + CUR_CML));
        DBGFS_DUMP(CUR_AWS);
        DBGFS_DUMP(CUR_AWE);
-       seq_puts(s, "\n");
-
+       seq_putc(s, '\n');
        return 0;
 }
 

diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
index bb23318a44b714a3d5d98883fcdc00234ddd3f16..24ebc6b2f34d1db80fdd0645b34e71badcb1df68 100644 (file)
--- a/drivers/gpu/drm/sti/sti_dvo.c
+++ b/drivers/gpu/drm/sti/sti_dvo.c
@@ -186,8 +186,7 @@ static int dvo_dbg_show(struct seq_file *s, void *data)
        DBGFS_DUMP(DVO_LUT_PROG_MID);
        DBGFS_DUMP(DVO_LUT_PROG_HIGH);
        dvo_dbg_awg_microcode(s, dvo->regs + DVO_DIGSYNC_INSTR_I);
-       seq_puts(s, "\n");
-
+       seq_putc(s, '\n');
        return 0;
 }
 

diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c
index e3475a17eaeb7fe381e7ea3341324264a79862a3..d6ed909d9d75ffb45b61b364aea973d6b8751967 100644 (file)
--- a/drivers/gpu/drm/sti/sti_hda.c
+++ b/drivers/gpu/drm/sti/sti_hda.c
@@ -354,8 +354,7 @@ static int hda_dbg_show(struct seq_file *s, void *data)
        hda_dbg_awg_microcode(s, hda->regs + HDA_SYNC_AWGI);
        if (hda->video_dacs_ctrl)
                hda_dbg_video_dacs_ctrl(s, hda->video_dacs_ctrl);
-       seq_puts(s, "\n");
-
+       seq_putc(s, '\n');
        return 0;
 }
 

diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
index f8aa72a432c5ffbe3c728d0fb590488336051235..d824497e950e07e55c4eafc6d8a8b05e78af7a4c 100644 (file)
--- a/drivers/gpu/drm/sti/sti_hdmi.c
+++ b/drivers/gpu/drm/sti/sti_hdmi.c
@@ -592,7 +592,7 @@ static void hdmi_dbg_cfg(struct seq_file *s, int val)
 {
        int tmp;
 
-       seq_puts(s, "\t");
+       seq_putc(s, '\t');
        tmp = val & HDMI_CFG_HDMI_NOT_DVI;
        DBGFS_PRINT_STR("mode:", tmp ? "HDMI" : "DVI");
        seq_puts(s, "\t\t\t\t\t");
@@ -616,7 +616,7 @@ static void hdmi_dbg_sta(struct seq_file *s, int val)
 {
        int tmp;
 
-       seq_puts(s, "\t");
+       seq_putc(s, '\t');
        tmp = (val & HDMI_STA_DLL_LCK);
        DBGFS_PRINT_STR("pll:", tmp ? "locked" : "not locked");
        seq_puts(s, "\t\t\t\t\t");
@@ -632,7 +632,7 @@ static void hdmi_dbg_sw_di_cfg(struct seq_file *s, int val)
                               "once every field",
                               "once every frame"};
 
-       seq_puts(s, "\t");
+       seq_putc(s, '\t');
        tmp = (val & HDMI_IFRAME_CFG_DI_N(HDMI_IFRAME_MASK, 1));
        DBGFS_PRINT_STR("Data island 1:", en_di[tmp]);
        seq_puts(s, "\t\t\t\t\t");
@@ -664,16 +664,16 @@ static int hdmi_dbg_show(struct seq_file *s, void *data)
        DBGFS_DUMP("\n", HDMI_STA);
        hdmi_dbg_sta(s, hdmi_read(hdmi, HDMI_STA));
        DBGFS_DUMP("", HDMI_ACTIVE_VID_XMIN);
-       seq_puts(s, "\t");
+       seq_putc(s, '\t');
        DBGFS_PRINT_INT("Xmin:", hdmi_read(hdmi, HDMI_ACTIVE_VID_XMIN));
        DBGFS_DUMP("", HDMI_ACTIVE_VID_XMAX);
-       seq_puts(s, "\t");
+       seq_putc(s, '\t');
        DBGFS_PRINT_INT("Xmax:", hdmi_read(hdmi, HDMI_ACTIVE_VID_XMAX));
        DBGFS_DUMP("", HDMI_ACTIVE_VID_YMIN);
-       seq_puts(s, "\t");
+       seq_putc(s, '\t');
        DBGFS_PRINT_INT("Ymin:", hdmi_read(hdmi, HDMI_ACTIVE_VID_YMIN));
        DBGFS_DUMP("", HDMI_ACTIVE_VID_YMAX);
-       seq_puts(s, "\t");
+       seq_putc(s, '\t');
        DBGFS_PRINT_INT("Ymax:", hdmi_read(hdmi, HDMI_ACTIVE_VID_YMAX));
        DBGFS_DUMP("", HDMI_SW_DI_CFG);
        hdmi_dbg_sw_di_cfg(s, hdmi_read(hdmi, HDMI_SW_DI_CFG));
@@ -712,8 +712,7 @@ static int hdmi_dbg_show(struct seq_file *s, void *data)
        DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD4, HDMI_IFRAME_SLOT_VENDOR);
        DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD5, HDMI_IFRAME_SLOT_VENDOR);
        DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD6, HDMI_IFRAME_SLOT_VENDOR);
-       seq_puts(s, "\n");
-
+       seq_putc(s, '\n');
        return 0;
 }
 

diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
index 66f843148ef7f5cd25e515fcc49ef4bfc4acba2f..372ea294da80e4997921b1eb02422be3422f9476 100644 (file)
--- a/drivers/gpu/drm/sti/sti_hqvdp.c
+++ b/drivers/gpu/drm/sti/sti_hqvdp.c
@@ -625,8 +625,7 @@ static int hqvdp_dbg_show(struct seq_file *s, void *data)
                hqvdp_dbg_dump_cmd(s, (struct sti_hqvdp_cmd *)virt);
        }
 
-       seq_puts(s, "\n");
-
+       seq_putc(s, '\n');
        return 0;
 }
 

diff --git a/drivers/gpu/drm/sti/sti_mixer.c b/drivers/gpu/drm/sti/sti_mixer.c
index 4ddc58f7fe2e98bfb8e1f69123263ae22e5358c1..2bd1d46fe1cd32f5f8256fdc22688c5685f8185e 100644 (file)
--- a/drivers/gpu/drm/sti/sti_mixer.c
+++ b/drivers/gpu/drm/sti/sti_mixer.c
@@ -162,8 +162,7 @@ static int mixer_dbg_show(struct seq_file *s, void *arg)
        DBGFS_DUMP(GAM_MIXER_MBP);
        DBGFS_DUMP(GAM_MIXER_MX0);
        mixer_dbg_mxn(s, mixer->regs + GAM_MIXER_MX0);
-       seq_puts(s, "\n");
-
+       seq_putc(s, '\n');
        return 0;
 }
 

diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
index 8b8ea717c121f0ba89809bcb0aa4caff31c16305..63b982048743f66f3884165ffe9bcd6d405fd3c4 100644 (file)
--- a/drivers/gpu/drm/sti/sti_tvout.c
+++ b/drivers/gpu/drm/sti/sti_tvout.c
@@ -459,7 +459,7 @@ static void tvout_dbg_vip(struct seq_file *s, int val)
                                   "Aux (color matrix by-passed)",
                                   "", "", "", "", "", "Force value"};
 
-       seq_puts(s, "\t");
+       seq_putc(s, '\t');
        mask = TVO_VIP_REORDER_MASK << TVO_VIP_REORDER_R_SHIFT;
        r = (val & mask) >> TVO_VIP_REORDER_R_SHIFT;
        mask = TVO_VIP_REORDER_MASK << TVO_VIP_REORDER_G_SHIFT;
@@ -558,8 +558,7 @@ static int tvout_dbg_show(struct seq_file *s, void *data)
        DBGFS_DUMP(TVO_CSC_AUX_M6);
        DBGFS_DUMP(TVO_CSC_AUX_M7);
        DBGFS_DUMP(TVO_AUX_IN_VID_FORMAT);
-       seq_puts(s, "\n");
-
+       seq_putc(s, '\n');
        return 0;
 }
 

diff --git a/drivers/gpu/drm/sti/sti_vid.c b/drivers/gpu/drm/sti/sti_vid.c
index 2ad59892b57e254fffa4467aebe8039d8260181f..577a3341d3c13f18cba9943a68b9fdb72fd70fb3 100644 (file)
--- a/drivers/gpu/drm/sti/sti_vid.c
+++ b/drivers/gpu/drm/sti/sti_vid.c
@@ -61,7 +61,7 @@
 static void vid_dbg_ctl(struct seq_file *s, int val)
 {
        val = val >> 30;
-       seq_puts(s, "\t");
+       seq_putc(s, '\t');
 
        if (!(val & 1))
                seq_puts(s, "NOT ");
@@ -114,8 +114,7 @@ static int vid_dbg_show(struct seq_file *s, void *arg)
        DBGFS_DUMP(VID_BC);
        DBGFS_DUMP(VID_TINT);
        DBGFS_DUMP(VID_CSAT);
-       seq_puts(s, "\n");
-
+       seq_putc(s, '\n');
        return 0;
 }