s390/qeth: don't mask TX errors on IQD devices
authorJulian Wiedmann <jwi@linux.ibm.com>
Tue, 11 Jun 2019 16:37:48 +0000 (18:37 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 14 Jun 2019 05:39:31 +0000 (22:39 -0700)
Current code suppresses debug entries when an TX buffer completes in
ERROR state with no error indication set in SBALF15.
This was introduced back with
commit 58490f18071d ("qeth: HiperSockets SIGA retry support on CC=2.").
But qeth no longer retries after CC=2, and this sort of suppression
make no sense anymore. Remove it.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_core_main.c

index b1823d75dd35cd26d7866c981dafac10432e3429..cd9e2f70d8f657a6846a12c0f93f939cd27ded79 100644 (file)
@@ -3236,13 +3236,6 @@ static void qeth_handle_send_error(struct qeth_card *card,
        int sbalf15 = buffer->buffer->element[15].sflags;
 
        QETH_CARD_TEXT(card, 6, "hdsnderr");
-       if (IS_IQD(card)) {
-               if (sbalf15 == 0) {
-                       qdio_err = 0;
-               } else {
-                       qdio_err = 1;
-               }
-       }
        qeth_check_qdio_errors(card, buffer->buffer, qdio_err, "qouterr");
 
        if (!qdio_err)