scsi: qedf: Fix error return code in __qedf_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 17 Jan 2018 12:42:41 +0000 (12:42 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 23 Jan 2018 01:03:56 +0000 (20:03 -0500)
Fix to return error code -ENOMEM from the error handling case instead of
0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Chad Dupuis <chad.dupuis@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qedf/qedf_main.c

index 7c0064500cc528a9d8c29e3ecd4ff66f005717d6..4809debc6110154f9c93cc8105768efd0d667942 100644 (file)
@@ -3126,6 +3126,7 @@ static int __qedf_probe(struct pci_dev *pdev, int mode)
        qedf->cmd_mgr = qedf_cmd_mgr_alloc(qedf);
        if (!qedf->cmd_mgr) {
                QEDF_ERR(&(qedf->dbg_ctx), "Failed to allocate cmd mgr.\n");
+               rc = -ENOMEM;
                goto err5;
        }
 
@@ -3149,6 +3150,7 @@ static int __qedf_probe(struct pci_dev *pdev, int mode)
                create_workqueue(host_buf);
        if (!qedf->ll2_recv_wq) {
                QEDF_ERR(&(qedf->dbg_ctx), "Failed to LL2 workqueue.\n");
+               rc = -ENOMEM;
                goto err7;
        }
 
@@ -3192,6 +3194,7 @@ static int __qedf_probe(struct pci_dev *pdev, int mode)
        if (!qedf->timer_work_queue) {
                QEDF_ERR(&(qedf->dbg_ctx), "Failed to start timer "
                          "workqueue.\n");
+               rc = -ENOMEM;
                goto err7;
        }