iwlwifi: pcie: don't dump useless data when a TFD queue hangs
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Sun, 25 Jan 2015 13:54:40 +0000 (15:54 +0200)
committerEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Sun, 1 Feb 2015 13:39:08 +0000 (15:39 +0200)
Printing all the scratch data of the TFDs of that queue is
useless and stuffed the kernel log with data. Remove that.

Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
drivers/net/wireless/iwlwifi/pcie/tx.c

index d40cd4a67d6e07c58c78b1e56b98f1ca118f4da9..6c7bfe8905ca3d309cda2b6c019d17890c7d00c8 100644 (file)
@@ -147,7 +147,6 @@ static void iwl_pcie_free_dma_ptr(struct iwl_trans *trans,
 static void iwl_pcie_txq_stuck_timer(unsigned long data)
 {
        struct iwl_txq *txq = (void *)data;
-       struct iwl_queue *q = &txq->q;
        struct iwl_trans_pcie *trans_pcie = txq->trans_pcie;
        struct iwl_trans *trans = iwl_trans_pcie_get_trans(trans_pcie);
        u32 scd_sram_addr = trans_pcie->scd_base_addr +
@@ -198,11 +197,6 @@ static void iwl_pcie_txq_stuck_timer(unsigned long data)
                        iwl_read_prph(trans, SCD_QUEUE_WRPTR(i)));
        }
 
-       for (i = q->read_ptr; i != q->write_ptr;
-            i = iwl_queue_inc_wrap(i))
-               IWL_ERR(trans, "scratch %d = 0x%08x\n", i,
-                       le32_to_cpu(txq->scratchbufs[i].scratch));
-
        iwl_force_nmi(trans);
 }