PCI/AER: Clear only ERR_NONFATAL bits during non-fatal recovery
authorOza Pawandeep <poza@codeaurora.org>
Thu, 19 Jul 2018 22:58:05 +0000 (17:58 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 20 Jul 2018 20:27:08 +0000 (15:27 -0500)
pci_cleanup_aer_uncorrect_error_status() is called by driver .slot_reset()
methods when handling ERR_NONFATAL errors.  Previously this cleared *all*
the bits, including ERR_FATAL bits.

Since we're only handling ERR_NONFATAL errors, clear only the ERR_NONFATAL
error status bits.

Signed-off-by: Oza Pawandeep <poza@codeaurora.org>
[bhelgaas: split to separate patch]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/pcie/aer.c

index b776a768a434af64667c5685e49235fe39e90d87..f853e72524be569d06554878383d862a879c79ce 100644 (file)
@@ -385,13 +385,16 @@ EXPORT_SYMBOL_GPL(pci_disable_pcie_error_reporting);
 int pci_cleanup_aer_uncorrect_error_status(struct pci_dev *dev)
 {
        int pos;
-       u32 status;
+       u32 status, sev;
 
        pos = dev->aer_cap;
        if (!pos)
                return -EIO;
 
+       /* Clear status bits for ERR_NONFATAL errors only */
        pci_read_config_dword(dev, pos + PCI_ERR_UNCOR_STATUS, &status);
+       pci_read_config_dword(dev, pos + PCI_ERR_UNCOR_SEVER, &sev);
+       status &= ~sev;
        if (status)
                pci_write_config_dword(dev, pos + PCI_ERR_UNCOR_STATUS, status);