ibmvnic: Revert to previous mtu when unsupported value requested

If we request an unsupported mtu value, the vnic server will suggest a
different value. Currently we take the suggested value without question
and login with that value. However, the behavior doesn't seem completely
sane as attempting to change the mtu to some specific value will change
the mtu to some completely different value most of the time. This patch
fixes the issue by logging in with the previously used mtu value and
printing an error message saying that the given mtu is unsupported.

Signed-off-by: John Allen <jallen@linux.vnet.ibm.com>
Reviewed-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 7f75d01432eff478b02b2f67547977b7855911a5..cc36b254917cc5045ce11f8ca02e8f0728ddadaa 100644 (file)
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -3623,7 +3623,17 @@ static void handle_request_cap_rsp(union ibmvnic_crq *crq,
                         *req_value,
                         (long int)be64_to_cpu(crq->request_capability_rsp.
                                               number), name);
-               *req_value = be64_to_cpu(crq->request_capability_rsp.number);
+
+               if (be16_to_cpu(crq->request_capability_rsp.capability) ==
+                   REQ_MTU) {
+                       pr_err("mtu of %llu is not supported. Reverting.\n",
+                              *req_value);
+                       *req_value = adapter->fallback.mtu;
+               } else {
+                       *req_value =
+                               be64_to_cpu(crq->request_capability_rsp.number);
+               }
+
                ibmvnic_send_req_caps(adapter, 1);
                return;
        default: