ipmi/powernv: Fix error return code in ipmi_powernv_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 18 Jan 2018 01:43:19 +0000 (01:43 +0000)
committerCorey Minyard <cminyard@mvista.com>
Mon, 22 Jan 2018 14:10:37 +0000 (08:10 -0600)
Fix to return a negative error code from the request_irq() error
handling case instead of 0, as done elsewhere in this function.

Fixes: dce143c3381c ("ipmi/powernv: Convert to irq event interface")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/ipmi_powernv.c

index c687c8d57c9298bdb6c894b195b84c59f4e8229e..bcf493d8e2387b6dc9979a86432ec9aac85ae9f7 100644 (file)
@@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev)
                ipmi->irq = opal_event_request(prop);
        }
 
-       if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
-                               "opal-ipmi", ipmi)) {
+       rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
+                        "opal-ipmi", ipmi);
+       if (rc) {
                dev_warn(dev, "Unable to request irq\n");
                goto err_dispose;
        }