staging: lustre: osc: remove unused variable
authorAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Fri, 27 Feb 2015 12:55:54 +0000 (14:55 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 2 Mar 2015 00:28:07 +0000 (16:28 -0800)
This patch removes a variable that was simply used to
store the return value of a function call before
returning it.

The issue was detected and resolved using the following
coccinelle script:

@@
identifier len,f;
@@

-int len;
 ... when != len
     when strict
-len =
+return
        f(...);
-return len;

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/osc/lproc_osc.c

index 1795d3a7a02954d28a5de04e8e9c220a4045a75f..3ef2b554b65cfb4ed2d9cb079dcc4cce95c3a50f 100644 (file)
@@ -164,16 +164,13 @@ static int osc_cached_mb_seq_show(struct seq_file *m, void *v)
        struct obd_device *dev = m->private;
        struct client_obd *cli = &dev->u.cli;
        int shift = 20 - PAGE_CACHE_SHIFT;
-       int rc;
 
-       rc = seq_printf(m,
+       return seq_printf(m,
                      "used_mb: %d\n"
                      "busy_cnt: %d\n",
                      (atomic_read(&cli->cl_lru_in_list) +
                        atomic_read(&cli->cl_lru_busy)) >> shift,
                      atomic_read(&cli->cl_lru_busy));
-
-       return rc;
 }
 
 /* shrink the number of caching pages to a specific number */